[Bug 4114] New: opac-detail.tmpl contains duplicate id definition
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4114 Summary: opac-detail.tmpl contains duplicate id definition Product: Koha Version: unspecified Platform: PC OS/Version: Windows NT Status: ASSIGNED Severity: trivial Priority: PATCH-Sent Component: OPAC AssignedTo: gcollum@gmail.com ReportedBy: gcollum@gmail.com Estimated Hours: 0.0 Change sponsored?: --- opac-detail.tmpl contains duplicate id definition. <body id="opac-detail"> and <div id="opac-detail"> -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4114 --- Comment #1 from Garry Collum <gcollum@gmail.com> 2010-02-05 01:48:28 --- Created an attachment (id=1535) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1535) Proposed patch -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2010-02-05 02:00:21 --- The proposed patch removes the body ID, which conflicts with Bug 3780 (my fix for which caused this bug I'm sure). The solution should be to make the IDs different. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4114 --- Comment #3 from Garry Collum <gcollum@gmail.com> 2010-02-05 12:50:09 --- I sort of hate not calling the id in the <body> 'opac-detail' since you followed this convention with other pages. How about if I change the id in the div and try to find any references to it in css and/or javascript. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4114 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2010-02-05 13:18:56 --- I think the div id is present as a hook for custom CSS (as is the body id) rather than for any built-in function. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4114 --- Comment #5 from Garry Collum <gcollum@gmail.com> 2010-02-05 20:38:06 --- Created an attachment (id=1558) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1558) Follow-up patch -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4114 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> 2010-02-06 00:02:13 --- Pushed follow-up. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4114 Garry Collum <gcollum@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com