[Bug 22458] New: PatronSelfRegistrationEmailMustBeUnique disallows self modification requests if multiple accounts share an email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Bug ID: 22458 Summary: PatronSelfRegistrationEmailMustBeUnique disallows self modification requests if multiple accounts share an email address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jrobb@sekls.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- PatronSelfRegistrationEmailMustBeUnique causes unexpected behavior on the patron self modification screen ("your personal details") in the OPAC. When enabled, the system preference blocks existing accounts from submitting account modification requests if the primary email associated with the account is also associated with another account in the database. This means if a parent account and a child account both use the same email address, neither can submit account modification requests via the OPAC. This system preference should only affect new self registered accounts. To reproduce this behavior: 1. Set PatronSelfRegistrationEmailMustBeUnique to 'Consider' 2. Create two different accounts with the same primary email address 3. Log into the OPAC with either account 4. Visit "your personal details" 5. Make a change unrelated to email address and submit 6. The submission is blocked with a message about duplicate email addresses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org --- Comment #1 from Chris Slone <cslone@camdencountylibrary.org> --- Can confirm that this is an issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19366 Depends on| |16275 CC| |andrew@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- It's clear from bug 16275 that this check was only meant to apply to self-registration, not self-modification. We should make this system preference only impact self-registration. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 [Bug 16275] Prevent patron self registration if the email already filled in borrowers.email -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 180306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180306&action=edit Bug 22458: Don't check for duplicate email on borrower self modification This patch adds an extra variable to internal function CheckValidBorrower to set the context as 'create' or 'update' To test: 1 - Enable PatronSelfRegistrationEmailMustBeUnique 2 - Edit a patron in staff interface and set email to 'a@example.org' 3 - Open an incognito window and go to opac 4 - Self register a patron using email a@example.org 5 - You receive an error 6 - Use b@example.org for email 7 - No problem 8 - Sign in as the new patron 9 - Edit your information 10 - Set email to a@example.org 11 - You receive an error 12 - Apply patch, restart all 13 - Edit patron again 14 - No error! 15 - Register another patron on the opac 16 - Confirm still wanred if using a@example.org as the email -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180306|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 180424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180424&action=edit Bug 22458: Don't check for duplicate email on borrower self modification This patch adds an extra variable to internal function CheckValidBorrower to set the context as 'create' or 'update' To test: 1 - Enable PatronSelfRegistrationEmailMustBeUnique 2 - Edit a patron in staff interface and set email to 'a@example.org' 3 - Open an incognito window and go to opac 4 - Self register a patron using email a@example.org 5 - You receive an error 6 - Use b@example.org for email 7 - No problem 8 - Sign in as the new patron 9 - Edit your information 10 - Set email to a@example.org 11 - You receive an error 12 - Apply patch, restart all 13 - Edit patron again 14 - No error! 15 - Register another patron on the opac 16 - Confirm still wanred if using a@example.org as the email Signed-off-by: Guillen, Allax <AGuillen@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180424|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 180443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180443&action=edit Bug 22458: Don't check for duplicate email on borrower self modification This patch adds an extra variable to internal function CheckValidBorrower to set the context as 'create' or 'update' To test: 1 - Enable PatronSelfRegistrationEmailMustBeUnique 2 - Edit a patron in staff interface and set email to 'a@example.org' 3 - Open an incognito window and go to opac 4 - Self register a patron using email a@example.org 5 - You receive an error 6 - Use b@example.org for email 7 - No problem 8 - Sign in as the new patron 9 - Edit your information 10 - Set email to a@example.org 11 - You receive an error 12 - Apply patch, restart all 13 - Edit patron again 14 - No error! 15 - Register another patron on the opac 16 - Confirm still wanred if using a@example.org as the email Signed-off-by: Guillen, Allax <AGuillen@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180443|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 180444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180444&action=edit Bug 22458: Don't check for duplicate email on borrower self modification This patch adds an extra variable to internal function CheckValidBorrower to set the context as 'create' or 'update' To test: 1 - Enable PatronSelfRegistrationEmailMustBeUnique 2 - Edit a patron in staff interface and set email to 'a@example.org' 3 - Open an incognito window and go to opac 4 - Self register a patron using email a@example.org 5 - You receive an error 6 - Use b@example.org for email 7 - No problem 8 - Sign in as the new patron 9 - Edit your information 10 - Set email to a@example.org 11 - You receive an error 12 - Apply patch, restart all 13 - Edit patron again 14 - No error! 15 - Register another patron on the opac 16 - Confirm still wanred if using a@example.org as the email Signed-off-by: Guillen, Allax <AGuillen@roseville.ca.us> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@openfifth.c | |o.uk Assignee|oleonard@myacpl.org |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- All methods of opac/opac-memberentry.pl should move to a module to be able to create unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org