https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35033 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Created attachment 156852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156852&action=edit Bug 35033: Add a validation for biblioitems in about/system information In the About section, under the System information tab, we get validation between issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart. But there's no validation for biblioitems. This patch will simply add the same test (and display) as the others, but for biblioitems. Testing 0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created. 1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber. An simple SQL will do insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin; 2) Go to about, see there's no warning in systeminformation. 3) apply the patch, validate that an error appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35033 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156852|0 |1 is obsolete| | --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- Created attachment 156853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156853&action=edit Bug 35033: Add a validation for biblioitems in about/system information In the About section, under the System information tab, we get validation between issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart. But there's no validation for biblioitems. This patch will simply add the same test (and display) as the others, but for biblioitems. Testing 0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created. 1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber. An simple SQL will do insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin; 2) Go to about, see there's no warning in systeminformation. 3) apply the patch, validate that an error appears. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35033 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156853|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 157621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157621&action=edit Bug 35033: Add a validation for biblioitems in about/system information In the About section, under the System information tab, we get validation between issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart. But there's no validation for biblioitems. This patch will simply add the same test (and display) as the others, but for biblioitems. Testing 0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created. 1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber. An simple SQL will do insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin; 2) Go to about, see there's no warning in systeminformation. 3) apply the patch, validate that an error appears. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35033 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157621|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 158098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158098&action=edit Bug 35033: Add a validation for biblioitems in about/system information In the About section, under the System information tab, we get validation between issues, borrowers, biblio, items, reserves tables, and their deleted/old counterpart. But there's no validation for biblioitems. This patch will simply add the same test (and display) as the others, but for biblioitems. Testing 0) Create a simple biblio entry through cataloguing. Note the biblioitemnumber created. 1) Insert a dummy entry in deletedbiblioitem using the biblioitemnumber. An simple SQL will do insert into deletedbiblioitems select * from biblioitems where biblioitemnumber = GIVENbin; 2) Go to about, see there's no warning in systeminformation. 3) apply the patch, validate that an error appears. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35033 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35033 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35033 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35033 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38617 -- You are receiving this mail because: You are watching all bug changes.