https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26240 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108532&action=edit Bug 26240: Move translatable strings out of sms_providers.tt and into sms_providers.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test you must have the SMSSendDriver preference populated ("Email" is fine). - Apply the patch and go to Administration -> SMS cellular providers. - Click "New SMS provider." - The legend on the form's fieldset should read "Add an SMS cellular provider." - Add an SMS provider. - Edit an SMS provider. - The legend on the form's fieldset should read "Edit provider <provider name>" - If necessary, edit a patron's SMS settings to use one of your existing SMS providers. - From the list of SMS providers, click to delete the provider which is in use. - The error message should read "Are you sure you want to delete <provider name>? <number> patron(s) are using it!" - Click to delete a provider which isn't in use. The error message should read "Are you sure you want to delete <provider>?" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:

cd misc/translator perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/sms_providers.js for translation, e.g.: msgid "Add an SMS cellular provider" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:

perl translate install fr-FR

- Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26240 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108532|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 110781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110781&action=edit Bug 26240: Move translatable strings out of sms_providers.tt and into sms_providers.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test you must have the SMSSendDriver preference populated ("Email" is fine). - Apply the patch and go to Administration -> SMS cellular providers. - Click "New SMS provider." - The legend on the form's fieldset should read "Add an SMS cellular provider." - Add an SMS provider. - Edit an SMS provider. - The legend on the form's fieldset should read "Edit provider <provider name>" - If necessary, edit a patron's SMS settings to use one of your existing SMS providers. - From the list of SMS providers, click to delete the provider which is in use. - The error message should read "Are you sure you want to delete <provider name>? <number> patron(s) are using it!" - Click to delete a provider which isn't in use. The error message should read "Are you sure you want to delete <provider>?" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:

cd misc/translator perl translate update fr-FR

- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/sms_providers.js for translation, e.g.: msgid "Add an SMS cellular provider" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:

perl translate install fr-FR

- Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26240 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26240 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.