[Bug 35692] New: ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Bug ID: 35692 Summary: ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It looks like between bug 30407 and bug 25560 we lost the line that made the update conditional: $item->notforloan($rules->{$key})->store({ log_action => 0, skip_record_index => 1, skip_holds_queue => 1 }) unless $rules->{$key} eq 'ONLYMESSAGE'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30407, 25560 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160499&action=edit Bug 35692: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160500&action=edit Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided To test: 1 - Set UpdateNotForLoanStatusOnCheckin to: _ALL_: -1: ONLYMESSAGE 2 - Set an item in the catalog as -1/Ordered 3 - Check the item in 4 - Confirm you see the message 5 - View the record details 6 - Item is now for loan 7 - Check item in again, no message 8 - Apply patch, restart all 9 - Set item as not for loan -1/Ordered 10 - Check item in, you see the message 11 - Check it in again, still see message 12 - Check the detail page, item still marked as ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Nick, I noticed that too! I submitted a patchset in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 but happy for your patchset to be upstreamed instead :) Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160499|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 160501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160501&action=edit Bug 35692: Unit test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160500|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 160502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160502&action=edit Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided To test: 1 - Set UpdateNotForLoanStatusOnCheckin to: _ALL_: -1: ONLYMESSAGE 2 - Set an item in the catalog as -1/Ordered 3 - Check the item in 4 - Confirm you see the message 5 - View the record details 6 - Item is now for loan 7 - Check item in again, no message 8 - Apply patch, restart all 9 - Set item as not for loan -1/Ordered 10 - Check item in, you see the message 11 - Check it in again, still see message 12 - Check the detail page, item still marked as ordered Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Nick, There is one difference between this and bug 35293 (the patchset I wrote) and that is 35293 re-adds the reference to ONLYMESSAGE into the UpdateNotForLoanStatusOnCheckin system preference which was also lost between bug 30407 and bug 25560 : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361 Would you like me to copy that patch over to your bug report here? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Alex Buckley from comment #6)
Hi Nick,
There is one difference between this and bug 35293 (the patchset I wrote) and that is 35293 re-adds the reference to ONLYMESSAGE into the UpdateNotForLoanStatusOnCheckin system preference which was also lost between bug 30407 and bug 25560 : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361
Would you like me to copy that patch over to your bug report here?
Thanks, Alex
Hi Alex, either way works, you could also just copy my unit test over to the other and then mark them duplicate. I didn't see yours initially because the depends on wasn't marked :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 35293 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Nick Clemens from comment #7)
(In reply to Alex Buckley from comment #6)
Hi Nick,
There is one difference between this and bug 35293 (the patchset I wrote) and that is 35293 re-adds the reference to ONLYMESSAGE into the UpdateNotForLoanStatusOnCheckin system preference which was also lost between bug 30407 and bug 25560 : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361
Would you like me to copy that patch over to your bug report here?
Thanks, Alex
Hi Alex, either way works, you could also just copy my unit test over to the other and then mark them duplicate. I didn't see yours initially because the depends on wasn't marked :-)
Thanks so much Nick for making those changes! Apologies for not marking the depends on for bug 35293 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 Bug 35692 depends on bug 25560, which changed state. Bug 25560 Summary: Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org