[Bug 9289] New: Adjacent checkbox behavior broken on circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Bug ID: 9289 Summary: Adjacent checkbox behavior broken on circulation.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In the table of checkouts on the circulation page you're not supposed to be able to check a box in both the renew and check-in column in the same row. The JavaScript which manages this works if you check the box itself, but there is also JavaScript which lets the user click anywhere in that cell to check the checkbox. If you do it this way the adjacent checkboxes are not prevented from both being checked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14151&action=edit Bug 9289 - Adjacent checkbox behavior broken on circulation.pl This patch fixes the behavior of adjacent checkboxes in the list of checkouts on circulation.pl. Checkboxes in both the "renew" and "check in" columns should not be able to be checked at the same time. A line was commented out (by me) which was necessary to this working correctly. I'm guessing it was done in debugging and left by mistake. To test, load a patron for checkout who has items checked out. You should not be able to check boxes in both the "renew" and "check in" columns in the same row, whether you click the checkbox itself or the containing table cell. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14151|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14250&action=edit Bug 9289 - Adjacent checkbox behavior broken on circulation.pl This patch fixes the behavior of adjacent checkboxes in the list of checkouts on circulation.pl. Checkboxes in both the "renew" and "check in" columns should not be able to be checked at the same time. A line was commented out (by me) which was necessary to this working correctly. I'm guessing it was done in debugging and left by mistake. To test, load a patron for checkout who has items checked out. You should not be able to check boxes in both the "renew" and "check in" columns in the same row, whether you click the checkbox itself or the containing table cell. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Trivial patch, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14250|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14261&action=edit Bug 9289 - Adjacent checkbox behavior broken on circulation.pl This patch fixes the behavior of adjacent checkboxes in the list of checkouts on circulation.pl. Checkboxes in both the "renew" and "check in" columns should not be able to be checked at the same time. A line was commented out (by me) which was necessary to this working correctly. I'm guessing it was done in debugging and left by mistake. To test, load a patron for checkout who has items checked out. You should not be able to check boxes in both the "renew" and "check in" columns in the same row, whether you click the checkbox itself or the containing table cell. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9289 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org