[Bug 34145] New: Patron search broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Bug ID: 34145 Summary: Patron search broken Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: justin@juicetoon.xyz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This is my console output: Uncaught TypeError: Cannot read properties of undefined (reading 'branchname') at render (members-home.pl:2483:76) at datatables.min_23.0500000.js:56:435 at b.fnGetData (datatables.min_23.0500000.js:50:221) at B (datatables.min_23.0500000.js:55:141) at Ha (datatables.min_23.0500000.js:63:1) at P (datatables.min_23.0500000.js:67:433) at vb (datatables.min_23.0500000.js:78:98) at datatables.min_23.0500000.js:75:167 at i (datatables.min_23.0500000.js:73:338) at Object.success (datatables.min_23.0500000.js:74:40) And this is where branchname appears in members-home.pl: in { "data": "library_id", "searchable": true, "orderable": true, "render": function( data, type, row, meta ) { let library_name = libraries_map[data].branchname if( !singleBranchMode && data == logged_in_library_id ) { return "<span class=\"currentlibrary\">" + escape_str(library_name) + "</span>"; } else { return escape_str(library_name); } } } It seems that this bug may be related: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31421 Though it says a fix was pushed to stable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Justin Dowswell <justin@juicetoon.xyz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |justin@juicetoon.xyz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- How can I reproduce this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34147 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think there is a confusion in Koha::Libraries->search_filtered, and we don't add the logged in library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153051&action=edit Bug 34145: Allow access the logged in branch's limited data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.05 |unspecified CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Justin, could you confirm this patch fixes your problem? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |nick@bywatersolutions.com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Nick, does this patch seem correct to you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The name is a killer :) sub libraries_where_can_see_things -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
Nick, does this patch seem correct to you?
I don't recreate, what is the setup? Also, without view_borrower_infos_from_any_libraries you can log into another branch, but still can't see their patrons, so I don't think we should be adding the logged in branch. Can you explain why we should? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we get some non-code summary on what happens here and a test plan? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I didn't recreate, the patch was just a guess. See also bug 34147. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- At the moment it looks like we have no information on how to make this bug appear. I have tested the patron search a lot for various bugs and couldn't detect an issue or this bug. I am downgrading this one. Please provide more information! * What is the exact version you are seeing this in * What is your setup? (IndependentBranches? Library groups?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bc@interleaf.ie --- Comment #11 from Barry Cannon <bc@interleaf.ie> --- I am not sure how useful this is but I found an instance where this can be recreated. If the branchcode on the borrowers table is in an different case to the branchcode on the branches table this problem can occur. MySQL doesn't care about case sensitivity but when javascript gets a hold of it branchcode != BRANCHCODE. Updating the borrowers table (or branches table) to make all the same case (upper or lower) resolved the issue. 23.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34145 --- Comment #12 from Barry Cannon <bc@interleaf.ie> --- I am not sure how useful this is but I found an instance where this can be recreated. If the branchcode on the borrowers table is in an different case to the branchcode on the branches table this problem can occur. MySQL doesn't care about case sensitivity but when javascript gets a hold of it branchcode != BRANCHCODE. Updating the borrowers table (or branches table) to make all the same case (upper or lower) resolved the issue. 23.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org