[Bug 25318] New: Convert authorities_js.inc to JavaScript file with translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Bug ID: 25318 Summary: Convert authorities_js.inc to JavaScript file with translatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Now that we can translate strings in JavaScript we can convert authorities_js.inc into a JavaScript file with language strings updated with the new JS translation function. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178537&action=edit Bug 25318: Convert authorities_js.inc to JavaScript file This patch creates a new JavaScript file, authorities.js, and includes it on pages which previously used authorities_js.inc. Some minor changes to the JavaScript have been made in order to pass JS variables instead of template variables. To test, apply the patch and go to Authorities. - Perform a search for authorities and test various features on the search result page:: - New from Z39.50/SRU - Actions -> Merge - Actions -> Delete - Action -> MARC preview - View the detail page for an authority record and test: - New from Z39.50/SRU - Edit -> Replace record via Z39.50/SRU - Edit -> Delete record - Go to Cataloging and create a new record. - Go to tab 1 and click the plugin trigger link on 100a. - Confirm that the authority search popup appears and works to add a selected author. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Merging throws "Uncaught ReferenceError: searchType is not defined." Since it's exactly what we were doing before (with the extra step of getting "" from [% marclist | html %] without a marclist), sticking a 'const searchType = "";' in merge.tt seems like the poetic fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178537|0 |1 is obsolete| | --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179299&action=edit Bug 25318: Convert authorities_js.inc to JavaScript file This patch creates a new JavaScript file, authorities.js, and includes it on pages which previously used authorities_js.inc. Some minor changes to the JavaScript have been made in order to pass JS variables instead of template variables. To test, apply the patch and go to Authorities. - Perform a search for authorities and test various features on the search result page:: - New from Z39.50/SRU - Actions -> Merge - Actions -> Delete - Action -> MARC preview - View the detail page for an authority record and test: - New from Z39.50/SRU - Edit -> Replace record via Z39.50/SRU - Edit -> Delete record - Go to Cataloging and create a new record. - Go to tab 1 and click the plugin trigger link on 100a. - Confirm that the authority search popup appears and works to add a selected author. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179300&action=edit Bug 25318: (follow-up) Make searchType be defined in merge.tt With authorities_js.inc doing "var searchType = '[% marclist | html %]';" in merge.tt where marclist isn't defined we got "var searchType = '';". This patch just adds 'const searchType = ""' directly to merge.tt to avoid a JavaScript console error. Test plan: 1. Open the devtools console 2. Do an authority search that returns at least two authorities 3. Select one, then another for merge 4. When the merge.pl page loads, observe an "Uncaught ReferenceError" in the console 5. Apply followup, repeat steps 1-3, without an "Uncaught ReferenceError" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- For the life of me, I can't figure out how to merge two authority records, I'm sure I've done it before! Here is what I did: 1. Go to Authorities. 2. Click the search button (arrow) in the staff interface header. Result: search results are displayed 3. For a record select Action > Merge. Result: Message is displayed in blue under the authority search results heading: Merging with authority: Ślez, Ts. (Tsevi), b. 1833. () Cancel merge 3. For another authority record of the same type (in this case Personal Names), go to Actions > Merge 4. I get a message saying: "You cannot merge a record with itself. Please select two different authorities." I'm sure if merging was broken, someone would have noticed by now 8-) Or I'm trying to merge incorrectly! It may be moot anyway, as I think Phil has signed the bug off - the status needs updating if that is the case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #8)
For the life of me, I can't figure out how to merge two authority records, I'm sure I've done it before!
You have discovered Bug 39874 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179299|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 182279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182279&action=edit Bug 25318: Convert authorities_js.inc to JavaScript file This patch creates a new JavaScript file, authorities.js, and includes it on pages which previously used authorities_js.inc. Some minor changes to the JavaScript have been made in order to pass JS variables instead of template variables. To test, apply the patch and go to Authorities. - Perform a search for authorities and test various features on the search result page:: - New from Z39.50/SRU - Actions -> Merge - Actions -> Delete - Action -> MARC preview - View the detail page for an authority record and test: - New from Z39.50/SRU - Edit -> Replace record via Z39.50/SRU - Edit -> Delete record - Go to Cataloging and create a new record. - Go to tab 1 and click the plugin trigger link on 100a. - Confirm that the authority search popup appears and works to add a selected author. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179300|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 182280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182280&action=edit Bug 25318: (follow-up) Make searchType be defined in merge.tt With authorities_js.inc doing "var searchType = '[% marclist | html %]';" in merge.tt where marclist isn't defined we got "var searchType = '';". This patch just adds 'const searchType = ""' directly to merge.tt to avoid a JavaScript console error. Test plan: 1. Open the devtools console 2. Do an authority search that returns at least two authorities 3. Select one, then another for merge 4. When the merge.pl page loads, observe an "Uncaught ReferenceError" in the console 5. Apply followup, repeat steps 1-3, without an "Uncaught ReferenceError" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39874 --- Comment #12 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #9)
(In reply to David Nind from comment #8)
For the life of me, I can't figure out how to merge two authority records, I'm sure I've done it before!
You have discovered Bug 39874
8-) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 [Bug 39874] Template error prevents authority merging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182279|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182284&action=edit Bug 25318: Convert authorities_js.inc to JavaScript file This patch creates a new JavaScript file, authorities.js, and includes it on pages which previously used authorities_js.inc. Some minor changes to the JavaScript have been made in order to pass JS variables instead of template variables. To test, apply the patch and go to Authorities. - Perform a search for authorities and test various features on the search result page:: - New from Z39.50/SRU - Actions -> Merge - Actions -> Delete - Action -> MARC preview - View the detail page for an authority record and test: - New from Z39.50/SRU - Edit -> Replace record via Z39.50/SRU - Edit -> Delete record - Go to Cataloging and create a new record. - Go to tab 1 and click the plugin trigger link on 100a. - Confirm that the authority search popup appears and works to add a selected author. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182280|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182285&action=edit Bug 25318: (follow-up) Make searchType be defined in merge.tt With authorities_js.inc doing "var searchType = '[% marclist | html %]';" in merge.tt where marclist isn't defined we got "var searchType = '';". This patch just adds 'const searchType = ""' directly to merge.tt to avoid a JavaScript console error. Test plan: 1. Open the devtools console 2. Do an authority search that returns at least two authorities 3. Select one, then another for merge 4. When the merge.pl page loads, observe an "Uncaught ReferenceError" in the console 5. Apply followup, repeat steps 1-3, without an "Uncaught ReferenceError" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #17 from David Nind <david@davidnind.com> --- No interface changes, no change required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Bug 25318 depends on bug 39874, which changed state. Bug 39874 Summary: Template error prevents authority merging https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39874 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org