[Bug 34934] New: Remove the use of event attributes from OPAC lists page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Bug ID: 34934 Summary: Remove the use of event attributes from OPAC lists page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: dcook@prosentient.com.au, fridolin.somers@biblibre.com, pedro.amorim@ptfs-europe.com, testopia@bugs.koha-community.org Blocks: 34709 There are some event attributes in the OPAC lists template. These should be removed in favor of defining events in JavaScript. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 [Bug 34709] Eliminate event handler attributes in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156298&action=edit Bug 34934: Remove the use of event attributes from OPAC lists page This patch removes the use of event attributes (onclick, onchange) from the OPAC lists template. These events are defined now along with the other in-page JS. The patch also removes a "delete list" button which was only shown when viewing an empty list and which was redundant. To test, apply the patch and log into the OPAC. - Go to Lists -> New list. - Change the category to "Private" and the "Allow changes" dropdown to "Staff only." - You should see a message, 'The "Staff only" permission has no actual effect while this list is strictly private' - Change the category to "Public." The message should disappear. - View the contents of a list. - Click the "Send list" button at the top of the table of titles. - It should trigger the "Sending your list" popup window. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156298|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 156313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156313&action=edit Bug 34934: Remove the use of event attributes from OPAC lists page This patch removes the use of event attributes (onclick, onchange) from the OPAC lists template. These events are defined now along with the other in-page JS. The patch also removes a "delete list" button which was only shown when viewing an empty list and which was redundant. To test, apply the patch and log into the OPAC. - Go to Lists -> New list. - Change the category to "Private" and the "Allow changes" dropdown to "Staff only." - You should see a message, 'The "Staff only" permission has no actual effect while this list is strictly private' - Change the category to "Public." The message should disappear. - View the contents of a list. - Click the "Send list" button at the top of the table of titles. - It should trigger the "Sending your list" popup window. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156313|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156391&action=edit Bug 34934: Remove the use of event attributes from OPAC lists page This patch removes the use of event attributes (onclick, onchange) from the OPAC lists template. These events are defined now along with the other in-page JS. The patch also removes a "delete list" button which was only shown when viewing an empty list and which was redundant. To test, apply the patch and log into the OPAC. - Go to Lists -> New list. - Change the category to "Private" and the "Allow changes" dropdown to "Staff only." - You should see a message, 'The "Staff only" permission has no actual effect while this list is strictly private' - Change the category to "Public." The message should disappear. - View the contents of a list. - Click the "Send list" button at the top of the table of titles. - It should trigger the "Sending your list" popup window. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34934 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org