[Bug 19171] New: Confusing message "no items available" on the holds page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Bug ID: 19171 Summary: Confusing message "no items available" on the holds page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When there are no items available to be placed on hold, the hold page in the OPAC reads for example: Sorry, none of these items can be placed on hold. No items available. To the patron this is confusing: - the record has items, but they are not showing (none of these...?) - the record may well have available items that are not shown, as a lot of libraries don't allow holds on items that are available. I think we could improve this already by rephrasing the message a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Confusing message "no items |Confusing message "no items |available" on the holds |available" when placing a |page |hold in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Upping severity as we have another library reporting this issue and it's confusing patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just got antoher report on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74710&action=edit Bug 19171: Attempt to make "no holds possible" messages less confusing At the moment, when no holds are possible, the OPAC reads something like: Sorry, none of these items can be placed on hold. No items available. This is confusing to the patrons, because the records have items, but they are not showing. The record also may have available items, they are just not permitted to place holds on them. Changes: - Only display the first message, when somoene tried unsuccessfully to place holds on multiple records. - Change first message to: Sorry, none of these titles can be placed on hold. - Change the second message to read: No items available to be placed on hold. - Remove <strong> around Sorry for better translatability. To test: - Try to place a hold on single record, where no hold is possible. - Try to place a hold on a single record, where a hold is possible. - Try to place holds on multiple records where no hold is possible. - Try to place holds on multiple records where at least one hold is possible. Verify the screen messages make sense in all cases. https://bugs.koha-community.org/show_bug.cgi?id=14716 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de CC| |oleonard@myacpl.org --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is an attempt to make the screen messages less confusing when it's not possible to place a hold. Might work well already or just be a starting point for discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 74710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74710 Bug 19171: Attempt to make "no holds possible" messages less confusing Review of attachment 74710: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19171&attachment=74710) ----------------------------------------------------------------- Failed QA for the excess tag, but it would be nice to get an answer the the question too. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ +22,4 @@
<div id="holds"> [% IF ( message ) %] <div id="holdmessages" class="alert"> + <p>Sorry, you cannot place holds.</strong></p>
I believe you forgot to remove the </strong> too. @@ +174,4 @@
<div class="alert">You have already requested this title.</div> [% ELSE %] [% UNLESS ( bibitemloo.bib_available ) %] + <div class="alert">There are no items that can be placed on hold.</div>
If you changed items to titles above, why not here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to M. Tompsett from comment #5)
Comment on attachment 74710 [details] [review] Bug 19171: Attempt to make "no holds possible" messages less confusing
Review of attachment 74710 [details] [review]: -----------------------------------------------------------------
Failed QA for the excess tag, but it would be nice to get an answer the the question too.
::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ +22,4 @@
<div id="holds"> [% IF ( message ) %] <div id="holdmessages" class="alert"> + <p>Sorry, you cannot place holds.</strong></p>
I believe you forgot to remove the </strong> too.
True.
@@ +174,4 @@
<div class="alert">You have already requested this title.</div> [% ELSE %] [% UNLESS ( bibitemloo.bib_available ) %] + <div class="alert">There are no items that can be placed on hold.</div>
If you changed items to titles above, why not here?
Because this one actually talks about items - the one above only appears now when you try to place a hold on multiple records. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74710|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74802&action=edit Bug 19171: Attempt to make "no holds possible" messages less confusing At the moment, when no holds are possible, the OPAC reads something like: Sorry, none of these items can be placed on hold. No items available. This is confusing to the patrons, because the records have items, but they are not showing. The record also may have available items, they are just not permitted to place holds on them. Changes: - Only display the first message, when somoene tried unsuccessfully to place holds on multiple records. - Change first message to: Sorry, none of these titles can be placed on hold. - Change the second message to read: No items available to be placed on hold. - Remove <strong> around Sorry for better translatability. To test: - Try to place a hold on single record, where no hold is possible. - Try to place a hold on a single record, where a hold is possible. - Try to place holds on multiple records where no hold is possible. - Try to place holds on multiple records where at least one hold is possible. Verify the screen messages make sense in all cases. https://bugs.koha-community.org/show_bug.cgi?id=14716 Fixed stray </strong> during signoff. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74802|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75059&action=edit Bug 19171: Attempt to make "no holds possible" messages less confusing At the moment, when no holds are possible, the OPAC reads something like: Sorry, none of these items can be placed on hold. No items available. This is confusing to the patrons, because the records have items, but they are not showing. The record also may have available items, they are just not permitted to place holds on them. Changes: - Only display the first message, when somoene tried unsuccessfully to place holds on multiple records. - Change first message to: Sorry, none of these titles can be placed on hold. - Change the second message to read: No items available to be placed on hold. - Remove <strong> around Sorry for better translatability. To test: - Try to place a hold on single record, where no hold is possible. - Try to place a hold on a single record, where a hold is possible. - Try to place holds on multiple records where no hold is possible. - Try to place holds on multiple records where at least one hold is possible. Verify the screen messages make sense in all cases. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Fixed stray </strong> during signoff. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> For consistency with staff, I renamed multi_holds to multi_hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. (We could still improve on holds :) Note that imo we do not need the multi_hold param in opac-reserve. If you have one title, 'none of these titles' is still true. And on the other hand, if you have two titles, we actually do not need the top level none_available message at all. We still see multiple lines with There are no items that can be placed on hold. No big deal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Agnes Rivers-Moore <arm@hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm@hanover.ca --- Comment #11 from Agnes Rivers-Moore <arm@hanover.ca> --- There are still confusing hold messages in the OPAC. I know this bug is closed. Adding this as information for others who may come across a similar situation: Test: logged into your account on Koha, search the catalogue for a title, forgetting that you already have a hold on it, and then try to place a hold on that title, the message that comes up is: "There are no items that can be placed on hold." No indication why not. This exists in versions up to 20.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30356 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30356 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org