http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 39476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39476&action=edit Bug 14267: How active is active? git grep on function active in additem.tt: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:function active(n koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:active([% koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:function a koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt: t/Cache.t: unless ( $cache->is_cache_active() && defined $cache ); t/Cache.t: unless ( $cache->is_cache_active() ); Conclusion: active in additem seems to be quite inactive. Test plan: Add, edit or delete items and verify that you did not miss active :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|How active is active? |How active is active in | |additem.tt? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39476|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39492&action=edit Bug 14267: How active is active? git grep on function active in additem.tt: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:function active(n koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:active([% koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:function a koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt: t/Cache.t: unless ( $cache->is_cache_active() && defined $cache ); t/Cache.t: unless ( $cache->is_cache_active() ); Conclusion: active in additem seems to be quite inactive. Test plan: Add, edit or delete items and verify that you did not miss active :) NOTE: The active function has a loop which is always run. Inside that loop 'ong' would always be defined as some number concatenated with XX. Both sides of the if/else reference document.getElementById(ong), but there is only one occurence of XX in the file: the concatenation! Similarly, the 'link' logic does not correspond to any of the id= or name= strings in the file. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt is the only file with "id=\"link" that matches the logic. This is likely a cut-and-paste remnant made useless by datatable upgrades and HTML/CSS class changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39492|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39508&action=edit Bug 14267: How active is active? git grep on function active in additem.tt: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:function active(n koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:active([% koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:function a koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt: t/Cache.t: unless ( $cache->is_cache_active() && defined $cache ); t/Cache.t: unless ( $cache->is_cache_active() ); Conclusion: active in additem seems to be quite inactive. Test plan: Add, edit or delete items and verify that you did not miss active :) NOTE: The active function has a loop which is always run. Inside that loop 'ong' would always be defined as some number concatenated with XX. Both sides of the if/else reference document.getElementById(ong), but there is only one occurence of XX in the file: the concatenation! Similarly, the 'link' logic does not correspond to any of the id= or name= strings in the file. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt is the only file with "id=\"link" that matches the logic. This is likely a cut-and-paste remnant made useless by datatable upgrades and HTML/CSS class changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.