https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20)

(In reply to Kyle M Hall from comment #19)

...

Would you please update the code to pass the object instead of the keys? It makes sense to avoid fetching all this data multiple times when there is no need to do so.

Kyle, I have written GetLatestAutoRenewDate following the same pattern as GetSoonestRenewDate. I have noticed the inconsistencies in this part of code but opted to keep it as it instead of making the code diverge. If you agree I'd prefer to fix the two subroutines on another bug report, instead of adding a follow-up on this one.

That sounds like a good plan to me! -- You are receiving this mail because: You are watching all bug changes.