[Bug 19441] New: Several tests are failing on 16.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Bug ID: 19441 Summary: Several tests are failing on 16.05.x Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org xt_sample_notices_t.No sample notice to add xt_sample_notices_t.No sample notice to delete t_db_dependent_XISBN_t.Gets correct biblionumber from a book with a similar isbn using XISBN t_db_dependent_Template_Plugin_AuthorisedValues_t t_db_dependent_Items_AutomaticItemModificationByAge_t t_db_dependent_Biblio_Isbd_t t_db_dependent_SIP_Message_t t_db_dependent_Koha_SearchEngine_Elasticsearch_Search_t t_db_dependent_Koha_SearchEngine_Elasticsearch_Search_t t_db_dependent_00_strict_t.Syntax check misc/search_tools/rebuild_elastic_search.pl t_db_dependent_Koha_Elasticsearch_Indexer_t t_db_dependent_Koha_Elasticsearch_Indexer_t t_db_dependent_Biblio_TransformKohaToMarc_t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67852&action=edit Bug 19441: Fix xt/sample_notices.t fr-CA is not up-to-date: - RESERVESLIP have been renamed with HOLD_SLIP - PASSWORD_RESET and MEMBERSHIP_EXPIRY are not defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67853&action=edit Bug 19441: Fix AuthorisedValues.t Koha::AuthorisedValueCategor[y|ies] do not exist in 16.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67854&action=edit Bug 19441: Fix AutomaticItemModificationByAge.t Koha::Caches does not exist in 16.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67855&action=edit Bug 19441: Fix t/db_dependent/Biblio/Isbd.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67856&action=edit Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t Koha::Caches and Koha::MarcSubfieldStructures do not exist in 16.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Mason, there are too much tests failing on 16.05.x, you really need to make sure the tests do not fail before you push stuffs. These patches should take care of most of the failures. After them, only ES-related tests will fail, I did not manage to find the cause of the problem (Nick maybe?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |16.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- I think it's an ES version conflict - Elasticsearch.pm is referencing settings of type 'string' and using an older syntax for facets (now 'aggregations') Related to 17255, ES for 16.11 and before only works with version 1.x of ES Skip the tests? or adjust tests to run with older ES? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nick Clemens from comment #7)
I think it's an ES version conflict - Elasticsearch.pm is referencing settings of type 'string' and using an older syntax for facets (now 'aggregations')
Related to 17255, ES for 16.11 and before only works with version 1.x of ES
Skip the tests? or adjust tests to run with older ES?
Skip the tests. A soon-to-die release, with no real ES support, we could even remove those. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67957&action=edit Bug 19441: Remove ES-related tests 16.05.x do not provided stable ES support, it will take us too much time to keep these tests up-to-date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #8)
we could even remove those.
granted! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67852|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68126&action=edit Bug 19441: Fix xt/sample_notices.t fr-CA is not up-to-date: - RESERVESLIP have been renamed with HOLD_SLIP - PASSWORD_RESET and MEMBERSHIP_EXPIRY are not defined Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67853|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68127&action=edit Bug 19441: Fix AuthorisedValues.t Koha::AuthorisedValueCategor[y|ies] do not exist in 16.05.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67854|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68128&action=edit Bug 19441: Fix AutomaticItemModificationByAge.t Koha::Caches does not exist in 16.05.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67855|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68129&action=edit Bug 19441: Fix t/db_dependent/Biblio/Isbd.t Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67856|0 |1 is obsolete| | --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68130&action=edit Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t Koha::Caches and Koha::MarcSubfieldStructures do not exist in 16.05.x Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67957|0 |1 is obsolete| | --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68131&action=edit Bug 19441: Remove ES-related tests 16.05.x do not provided stable ES support, it will take us too much time to keep these tests up-to-date. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- prove before patch failed as expected. prove after patch succeeded. delete from letter; source /home/vagrant/kohaclone/installer/data/mysql/fr-CA/obligatoire/sample_notices.sql sample notices still passed koha qa test tools passed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 --- Comment #18 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release thanks Jonathan :0) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- No apparent need to keep this in the SO queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19441 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org