[Bug 26848] New: Fix Readonly dependency in cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Bug ID: 26848 Summary: Fix Readonly dependency in cpanfile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 112647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112647&action=edit Bug 26848: Fix Readonly dependency in cpanfile - It is a required module. If it is missing, Koha will not start - Set the minimum version to 2.00. While not strictly required, it's the version that states that "Deprecation of Readonly::XS as a requirement for fast, readonly scalars is complete", it is available in Debian oldoldstable (jessie, 8), and Readonly::XS was not even needed with Perl > 5.8, which allows us to: - Remove dependency on Readonly::XS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 114271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114271&action=edit Bug 26848: Add Readonly::XS 1.05 as required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- hi Julian i did a quick test with a modified eg/benchmark.pl script, which indicates that Readonly's performance is 10x with the Readonly::XS module installed https://metacpan.org/source/SANKO/Readonly-2.05/eg/benchmark.pl so, i think it's still a good idea to install Readonly::XS - do you agree? mason@xen1:~/g/cpan/readonly$ perl eg/benchmark2.pl Benchmark: timing 10000000 iterations of rotie, rotie_xs,... ... rotie: 4 wallclock secs ( 4.19 usr + 0.00 sys = 4.19 CPU) @ 2386634.84/s (n=10000000) rotie_xs: -1 wallclock secs ( 0.38 usr + 0.00 sys = 0.38 CPU) @ 26315789.47/s (n=10000000) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Mason, What did you modify in the benchmark ? I ran the non-modified benchmark with and without Readonly::XS installed and I saw no differences. Also, on https://metacpan.org/pod/Readonly#Internals it is written:
In the years since Readonly::XS was released, the then private internal methods have been exposed and can be used in pure perl. Similar modules were written to take advantage of this and a patch to Readonly was created. We no longer need to build and install another module to make Readonly useful on modern builds of perl. - You do not need to install Readonly::XS. - You should stop listing Readonly::XS as a dependency or expect it to be installed. - Stop testing the $Readonly::XSokay variable!
So I think Readonly::XS should be removed from our cpanfile. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848
Mason James <mtj@kohaaloha.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #112647|0 |1
is obsolete| |
Attachment #114271|0 |1
is obsolete| |
--- Comment #5 from Mason James <mtj@kohaaloha.com> ---
Created attachment 114274
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114274&action=edit
Bug 26848: Fix Readonly dependency in cpanfile
- It is a required module. If it is missing, Koha will not start
- Set the minimum version to 2.00. While not strictly required, it's the
version that states that "Deprecation of Readonly::XS as a requirement
for fast, readonly scalars is complete", it is available in Debian
oldoldstable (jessie, 8), and Readonly::XS was not even needed with Perl
> 5.8, which allows us to:
- Remove dependency on Readonly::XS
Signed-off-by: Mason James <mtj@kohaaloha.com>
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to Julian Maurice from comment #4)
Hi Mason,
What did you modify in the benchmark ? I ran the non-modified benchmark with and without Readonly::XS installed and I saw no differences.
So I think Readonly::XS should be removed from our cpanfile.
hi Julian, i tested again and agree, so i will sign-off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848
Martin Renvoize <martin.renvoize@ptfs-europe.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #114274|0 |1
is obsolete| |
--- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> ---
Created attachment 115027
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115027&action=edit
Bug 26848: Fix Readonly dependency in cpanfile
- It is a required module. If it is missing, Koha will not start
- Set the minimum version to 2.00. While not strictly required, it's the
version that states that "Deprecation of Readonly::XS as a requirement
for fast, readonly scalars is complete", it is available in Debian
oldoldstable (jessie, 8), and Readonly::XS was not even needed with Perl
> 5.8, which allows us to:
- Remove dependency on Readonly::XS
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial fix.. also agree on the benchmark.. I can't replicate a speedup with ::XS. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.02 |21.05.00,20.11.02,20.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org