http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 12725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12725&action=edit Bug 8887 Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results) Removed superfluous test on exact match in preferences.pl (with return straight out the loop) Test scenario: a) Make sure you have defined a custom favicon using syspref IntranetFavicon b) In sysprefs, do a search with partioal match (e.g. intranetcolor) -> Result shows one entry: intranetcolorstylesheet, and favicon (in browser tab) displays as expected. d) Do an exact search. e.g. intranetcolorstylesheet -> Result shows all Staff Client preferences. Favicon (in browser tab) falls back to the Koha default icon Apply patch, test again. Now d) behaves like b), favicon displays as expected. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Staff Client Assignee|veron@veron.ch |koha-bugs@lists.koha-commun | |ity.org --- Comment #2 from Marc Véron <veron@veron.ch> --- Mistaked with module, changed to Staff Client. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Tested with default favicon ('new' staff client favicon) where the same thing happened. This patch fixes the problem and establishes consistency for the presentation of syspref search results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: I did not test the original issue. But you change the behaviour of the results. Without your patch, if I search with an exact match, the result page display all the syspref for the module. With your patch, the page only contains 1 result. I don't know if it is what the users want. I would like to have others point of view. In discussion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Jonathan Druart from comment #6)

I don't know if it is what the users want.

It is what *this* user wants -- this has been annoying me for years, albeit not enough to do anything about it. I do not find it intuitive that providing a more specific search string yields more hits, not fewer. The existing behavior was intentional -- see commit cdb3d52423f9 -- but IMO the "jump to preference" is only effective if the module (e.g., Circulation) has enough preferences to make the page long enough that the desired preference is scrolled to the top of the browser viewport. For most sysprefs, though, I end up having the scan the page for the one I just searched for, and it would be easier if the search just gave me only the one I was looking for. I recognize that opinions can differ on this, but thus far no contrary ones have actually been expressed. I've signed off on the patch and adjusted the wording of the commit description a bit. I did remove mention of the favicon, as I wasn't able to reproduce it and I think it's a moot issue. Status => Signed Off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20278|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20427&action=edit Bug 8887: only display desired result when doing exact syspref search This patch fixes an issue where entering the complete name of a system preference when doing a syspref search in the staff interface resulted in the display of *all* preferences belonging to the desired one's module. Since providing a more specific search string should result in getting back more specific results, the previous behavior was not intuitive. Test scenario: a) In sysprefs, do a search with partial match (e.g. intranetcolor) -> Result shows one entry: intranetcolorstylesheet b) Do an exact search. e.g. intranetcolorstylesheet -> Result shows all Staff Client preferences Apply patch, test again. Now b) behaves like a). Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Marc! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.