https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 159697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159697&action=edit Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Apply patch * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159697|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 159701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159701&action=edit Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that in the source code the aria-label for the checked and unchecked checkboxes reads: sms messaging * Verify that in the source code for the 'days in advance' pull down, the message reads "... receive notice" * Apply patch, restart all * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" * Verify that the aria-label on the 'days in advance' pull down now reads 'receive the message' Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159701|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 159710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159710&action=edit Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that in the source code the aria-label for the checked and unchecked checkboxes reads: sms messaging * Verify that in the source code for the 'days in advance' pull down, the message reads "... receive notice" * Apply patch, restart all * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" * Verify that the aria-label on the 'days in advance' pull down now reads 'receive the message' Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159710|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159953&action=edit Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that in the source code the aria-label for the checked and unchecked checkboxes reads: sms messaging * Verify that in the source code for the 'days in advance' pull down, the message reads "... receive notice" * Apply patch, restart all * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" * Verify that the aria-label on the 'days in advance' pull down now reads 'receive the message' Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.