[Bug 41311] New: Add ability for SIP to send patron hombranch in AO field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Bug ID: 41311 Summary: Add ability for SIP to send patron hombranch in AO field Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org SIP sends the configured institution ID in the AO field, but nearly every SIP-using vendor I've worked with assumes that the AO field will contain the patron's home branch code instead. We've dealt with this by creating custom fields, but it would be simpler and easier if we had the option of sending the patron's home branchcode in the AO field for patron status and patron information requests. The SIP2 spec lists is simply as "The library's institution ID" leaving pretty much everything about it up to interpretation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability for SIP to send |Add ability for SIP to send |patron hombranch in AO |patron home library ( |field |branchcode ) in AO field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 189974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189974&action=edit Bug 41311 - Add ability for SIP to send patron home library ( branchcode ) in AO field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 189975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189975&action=edit Bug 41311: Update DBIC [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 [Bug 37893] Migrate some SIP configuration into the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190080&action=edit Bug 41311 - Add ability for SIP to send patron home library ( branchcode ) in AO field Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190081&action=edit Bug 41311: Update DBIC [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189974|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190083&action=edit Bug 41311: Add ability for SIP to send patron home library ( branchcode ) in AO field Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190084&action=edit Bug 41311: Update DBIC [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #7 from Lisette Scheer <lisette@bywatersolutions.com> --- Can you please add a test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #8 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Test Plan: 1) Apply this patch 2) Ensure the patron you use for testing has a different home branch than the institution code set for the SIP account you will be testing with 3) Run a patron information request for the patron you have chosen 4) Note the AO field in the response contains the institution code you've chosen 5) Enable the "Send patron home library in AO" option for the SIP account you are using 6) Repeat step 3 7) Note the AO field now has the patron's home library in the AO field! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190083|0 |1 is obsolete| | --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 195133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195133&action=edit Bug 41311: Add ability for SIP to send patron home library ( branchcode ) in AO field Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190084|0 |1 is obsolete| | --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 195134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195134&action=edit Bug 41311: Update DBIC [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #11 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 195135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195135&action=edit Bug 41311: (QA follow-up) Adjust schema for boolean Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.05 |Main CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- The kohastructure.sql and database update need to match, currently they do not. Also when running the updatedatabase more than once: DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_41311.pl [17:04:36]: Bug 41311 - Add patron_branchcode_in_ao to sip_accounts table ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate column name 'patron_branchcode_in_ao' at /kohadevbox/koha/C4/Installer.pm line 817 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #13 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 196943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196943&action=edit Bug 41311: (QA follow-up) Fix database update and table structure Patch from commit 4eb3136 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197453&action=edit Bug 41311: (RM follow-up) Make DBRev match schema Patch from commit 4bdf8f8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Causing a test to fail now: kohadev-koha@kohadevbox:koha(main)$ prove -v /kohadevbox/koha/t/db_dependent/Koha/SIP2/SIP2ModuleMigration.t /kohadevbox/koha/t/db_dependent/Koha/SIP2/SIP2ModuleMigration.t .. 1..4 # Subtest: Config from XML matches config from database 1..4 ok 1 - fileSIPconfig->{accounts} has 5 members ok 2 - Database does not yet contain any accounts ok 3 - Database now contains 5 accounts not ok 4 - config from XML file matches config from database # Failed test 'config from XML file matches config from database' # at /kohadevbox/koha/t/db_dependent/Koha/SIP2/SIP2ModuleMigration.t line 90. # Structures begin differing at: # $got->{accounts}{term1}{patron_branchcode_in_ao} = Does not exist # $expected->{accounts}{term1}{patron_branchcode_in_ao} = '0' # Looks like you failed 1 test of 4. not ok 1 - Config from XML matches config from database # Subtest: config_timestamp is updated when database configuration changes 1..3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #17 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 198158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198158&action=edit Bug 41311: (QA follow-up) Fix broken unit test Patch from commit 246326d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main, thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #19 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42652 [Bug 42652] Add per-account option to allow restricted patrons to retain SIP inet access -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #20 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Kyle M Hall (khall) from comment #0)
SIP sends the configured institution ID in the AO field, but nearly every SIP-using vendor I've worked with assumes that the AO field will contain the patron's home branch code instead. We've dealt with this by creating custom fields, but it would be simpler and easier if we had the option of sending the patron's home branchcode in the AO field for patron status and patron information requests.
The SIP2 spec lists is simply as "The library's institution ID" leaving pretty much everything about it up to interpretation.
YES!!!!! A SMART adjustment. You will be configuring less custom fields for the institution ID. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, could you check maybe if bug 13666 is a duplicate of this one maybe? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org