[Bug 31108] New: add missing shebang line to ./t/00-check-atomic-updates.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Bug ID: 31108 Summary: add missing shebang line to ./t/00-check-atomic-updates.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org small patch to add missing shebang line to ./t/00-check-atomic-updates.pl to test... 1/ run prove, test is not run :( prove ./t | grep 00-check-atomic-updates.pl | wc -l 0 2/ apply patch 3/ run prove, test is run :) prove ./t | grep 00-check-atomic-updates.pl | wc -l 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 137198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137198&action=edit Bug 31108: add missing shebang line to ./t/00-check-atomic-updates.pl small patch to add missing shebang line to ./t/00-check-atomic-updates.pl to test... 1/ run prove, test is not run :( prove ./t | grep 00-check-atomic-updates.pl | wc -l 0 2/ apply patch 3/ run prove, test is run :) prove ./t | grep 00-check-atomic-updates.pl | wc -l 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtj@kohaaloha.com Depends on| |19169 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 [Bug 19169] Add a test to detect unneeded 'atomicupdate' files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why do we need it? It's missing in some other files. Why this path? % git grep '/usr/bin/perl' t|wc -l 486 % git grep '/usr/bin/env perl' t|wc -l 43 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add missing shebang line to |rename |./t/00-check-atomic-updates |./t/00-check-atomic-updates |.pl |.pl extention to *.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137198|0 |1 is obsolete| | --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 137203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137203&action=edit Bug 31108: rename ./t/00-check-atomic-updates.pl extention to *.t to test... 1/ run prove, test is not run :( prove ./t | grep 00-check-atomic-updates.pl | wc -l 0 2/ apply patch 3/ run prove, test is run :) prove ./t | grep 00-check-atomic-updates.pl | wc -l 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #2)
Why do we need it?
ah, my mistake - the solution was to rename the file :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|rename |rename |./t/00-check-atomic-updates |./t/00-check-atomic-updates |.pl extention to *.t |.pl extension to *.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137203|0 |1 is obsolete| | --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 137204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137204&action=edit Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t to test... 1/ run prove, test is not run :( prove ./t | grep 00-check-atomic-updates.pl | wc -l 0 2/ apply patch 3/ run prove, test is run :) prove ./t | grep 00-check-atomic-updates.t | wc -l 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137204|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 137206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137206&action=edit Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t to test... 1/ run prove, test is not run :( prove ./t | grep 00-check-atomic-updates.pl | wc -l 0 2/ apply patch 3/ run prove, test is run :) prove ./t | grep 00-check-atomic-updates.t | wc -l 2 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- This is what I get after running step 1: prove ./t | grep 00-check-atomic-updates.pl | wc -l Use of uninitialized value $_ in pattern match (m//) at /usr/share/perl5/PPIx/Regexp/Structure/Quantifier.pm line 117. skipping ingest of QUOTES_413514.CEQ : filename exists at t/EdiTransport.t line 53. Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1. Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1. Use of uninitialized value $DisplayLibraryFacets in string eq at /kohadevbox/koha/C4/Koha.pm line 442. Use of uninitialized value $DisplayLibraryFacets in string eq at /kohadevbox/koha/C4/Koha.pm line 442. Use of uninitialized value $DisplayLibraryFacets in string eq at /kohadevbox/koha/C4/Koha.pm line 455. Use of uninitialized value $DisplayLibraryFacets in string eq at /kohadevbox/koha/C4/Koha.pm line 455. Use of uninitialized value $cn_item in sprintf at /kohadevbox/koha/C4/ClassSplitRoutine/LCC.pm line 48. # Failed test 'Logger did not init correctly without permission' # at t/Logger.t line 52. # Looks like you failed 1 test of 10. # Failed test 'Test01 -- Simple tests for Koha::Logger' # at t/Logger.t line 74. # Looks like you failed 1 test of 1. 0 This is what I get after running step 3: prove ./t | grep 00-check-atomic-updates.pl | wc -l Use of uninitialized value $_ in pattern match (m//) at /usr/share/perl5/PPIx/Regexp/Structure/Quantifier.pm line 117. skipping ingest of QUOTES_413514.CEQ : filename exists at t/EdiTransport.t line 53. Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1. Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1. Use of uninitialized value in string eq at /kohadevbox/koha/C4/Koha.pm line 315. Use of uninitialized value in string eq at /kohadevbox/koha/C4/Koha.pm line 315. Use of uninitialized value $DisplayLibraryFacets in string eq at /kohadevbox/koha/C4/Koha.pm line 442. Use of uninitialized value $DisplayLibraryFacets in string eq at /kohadevbox/koha/C4/Koha.pm line 442. Use of uninitialized value $DisplayLibraryFacets in string eq at /kohadevbox/koha/C4/Koha.pm line 455. Use of uninitialized value $DisplayLibraryFacets in string eq at /kohadevbox/koha/C4/Koha.pm line 455. Use of uninitialized value $cn_item in sprintf at /kohadevbox/koha/C4/ClassSplitRoutine/LCC.pm line 48. # Failed test 'Logger did not init correctly without permission' # at t/Logger.t line 52. # Looks like you failed 1 test of 10. # Failed test 'Test01 -- Simple tests for Koha::Logger' # at t/Logger.t line 74. # Looks like you failed 1 test of 1. 0 Signing off as file is renamed and tests pass for prove t/00-check-atomic-updates.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137206|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137213&action=edit Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t to test... 1/ run prove, test is not run :( prove ./t | grep 00-check-atomic-updates.pl | wc -l 0 2/ apply patch 3/ run prove, test is run :) prove ./t | grep 00-check-atomic-updates.t | wc -l 2 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to Tomás Cohen Arazi from comment #9)
Pushed to master for 22.11.
Nice work everyone, thanks!
thanks, can we push thru to o-o-stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker Version|master |22.05 Priority|P5 - low |P1 - high --- Comment #11 from Mason James <mtj@kohaaloha.com> --- bumping to blocker for 22.05.03 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30899 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.03-1, released in| |21.11.11 CC| |arthur.suzuki@biblibre.com --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to stable |RESOLVED Version(s)|22.11.00, 22.05.03-1, |22.11.00, 22.05.03-1, released in|21.11.11 |21.11.11, 21.05.18 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 21.05.x branch for 21.05.18 Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Was this tested with an actual atomic update in the directory? I had an atomic update in there named bug_X_-_add_syspref.pl and it caused the test to fail $ prove t/00-check-atomic-updates.t t/00-check-atomic-updates.t .. 1/? # Failed test 'check for unhandled atomic updates: bug_30880_-_add_option_OPACResultsUnavailableGroupingBy_syspref.pl' # at t/00-check-atomic-updates.t line 34. # 'bug_30880_-_add_option_OPACResultsUnavailableGroupingBy_syspref.pl' # matches '(?^u:.*pl$)' # Looks like you failed 1 test of 7. t/00-check-atomic-updates.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests Test Summary Report ------------------- t/00-check-atomic-updates.t (Wstat: 256 Tests: 7 Failed: 1) Failed test: 5 Non-zero exit status: 1 Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.06 cusr 0.00 csys = 0.08 CPU) Result: FAIL Can anyone advise? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466 [Bug 31466] t/00-check-atomic-updates.t always fails if atomic update exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I've opened Bug 31466 to handle this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Never mind it has been explained to me that the test is correct and those of us doing custom packages will need to change how we handle atomic updates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 [Bug 31479] Provide an option to skip the test for atomic updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Bug 31108 depends on bug 19169, which changed state. Bug 19169 Summary: Add a test to detect unneeded 'atomicupdate' files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org