[Bug 24364] New: Display item holding library in opac issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Bug ID: 24364 Summary: Display item holding library in opac issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org Be able to display the item's holding library in OPAC issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 96894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96894&action=edit Bug 24364: Display item holding library in opac issues Test plan: 1) Create a SHOW_LIB patron attribute type, with YES_NO as authorized value category. (Administration -> Patron attribute types -> New patron attribute type) Check 'Display in OPAC' and 'Editable in OPAC' if you want users to be able to toggle library display themselves. 2) Set the SHOW_LIB attribute to yes for a given patron. 3) Check that the library is displayed in this patron's opac issues. ('Your summary' -> 'Checked out' and 'Overdue' tabs) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96894|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 97145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97145&action=edit Nice enchancement, thanks Matts! Bug 24364: Display item holding library in opac issues Test plan: 1) Create a SHOW_LIB patron attribute type, with YES_NO as authorized value category. (Administration -> Patron attribute types -> New patron attribute type) Check 'Display in OPAC' and 'Editable in OPAC' if you want users to be able to toggle library display themselves. 2) Set the SHOW_LIB attribute to yes for a given patron. 3) Check that the library is displayed in this patron's opac issues. ('Your summary' -> 'Checked out' and 'Overdue' tabs) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should not this be added to the .sql installer files? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if this should really be a per patron setting or not be using column configuration on the table that the library can decide on? Adding this might make it harder to convert later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This development uses SHOW_LIB in the same manner that Bug 4157 uses SHOW_BCODE. So I think SHOW_LIB should be added in patron_attributes.sql and patron_attributes.txt but not in installer.sql What is your opinion on this Jonathan ? Katrin, I made this dev in a way that is consistant with a similar setting, that is SHOW_BCODE from Bug 4157, but I'm open-minded about how it should be configured. When you say "[..] using column configuration on the table", can you be more explicit? What are you exactly referring to? Are there other settings already using what you are referring to? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Matthias Meusburger from comment #5)
This development uses SHOW_LIB in the same manner that Bug 4157 uses SHOW_BCODE.
So I think SHOW_LIB should be added in patron_attributes.sql and patron_attributes.txt but not in installer.sql What is your opinion on this Jonathan ?
Katrin, I made this dev in a way that is consistant with a similar setting, that is SHOW_BCODE from Bug 4157, but I'm open-minded about how it should be configured. When you say "[..] using column configuration on the table", can you be more explicit? What are you exactly referring to? Are there other settings already using what you are referring to?
Hi Matthias, I know about SHOW_BCODE, but always get the impression that it's confusing to people and not so helpful. For example you can't really set a default for patron attributes, so you'd have to turn it on for every single one, if a library wants this as a general default. I don't think putting it on the patron is ideal and they won't expect it on the details page. When SHOW_BCODE was added, it was not even possible yet for a patron to change these settings in the OPAC. It feels like these features are not well suited to work on top of the patron attributes system. It feels a bit hacky. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- As we have bug 18348, I think Katrin is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #8 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- So you're suggesting a proper column in the borrowers table and in the categories table, in order for this setting to be editable at both category-level and user-level, is that right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually my suggesting would be to check if this is needed on patron level or could be a global setting - and then throw a colvis table configuration at that table :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #9)
or could be a global setting - and then throw a colvis table configuration at that table :)
I agree that this change could be made without any patron-level limitations. I don't even think the column configuration is necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #11 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Okay, I'll submit an update with an on-off syspref then. Thanks for the feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Matthias Meusburger from comment #11)
Okay, I'll submit an update with an on-off syspref then. Thanks for the feedback.
I don't even think this needs a syspref. In my opinion it's relevant information to show. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #13 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 97431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97431&action=edit Bug 24364: Display item holding library in opac issues Test plan: Check that the library is displayed in patrons opac issues. ('Your summary' -> 'Checked out' and 'Overdue' tabs) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97145|0 |1 is obsolete| | Attachment #97431|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97440&action=edit Bug 24364: Display item holding library in opac issues Test plan: Check that the library is displayed in patrons opac issues. ('Your summary' -> 'Checked out' and 'Overdue' tabs) Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #14)
Created attachment 97440 [details] [review] Bug 24364: Display item holding library in opac issues
Test plan:
Check that the library is displayed in patrons opac issues. ('Your summary' -> 'Checked out' and 'Overdue' tabs)
Current status: Signed Off
Hi Owen, the patch is missing your sign-off line - did something go wrong here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please use the Branches TT plugin instead (Branches.GetName). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also I bet that this column does not make sense if IndependentBranches or singleBranchMode is set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It would be really nice if it could be hidden automatically for single branches or using the column configuration settings. We have similar checks for single branches in multiple places. I don't think IndependentBranches is a problem - you could still check otu items from different branches or get them via holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30221 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Is this covered by Bug 30221 ? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org