[Bug 36871] New: DefaultHoldPickupLocation = logged in library on multi-holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Bug ID: 36871 Summary: DefaultHoldPickupLocation = logged in library on multi-holds Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If DefaultHoldPickupLocation is set to logged in library, this should be taken into account when placing multi-holds. To recreate: 0. Make sure the DefaultHoldPickupLocation system preference is set to logged in library. 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) --> "Pickup at" and "Pickup location" are empty and the staff member must select the library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36870 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166857&action=edit Bug 36871: Honor DefaultHoldPickupLocation when placing holds for multiple items at once To test: 0. Make sure the DefaultHoldPickupLocation system preference is set to logged in library. 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) --> "Pickup location" is empty and the staff member must select the library 5. APPLY PATCH and restart_all 6. Try again, the default should be set according to the DefaultHoldPickupLocation system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- This patch sets the 'Pickup location' according to the DefaultHoldPickupLocation but not the 'Pickup at' higher up because I was unsure how you'd set that to the item's home/holding branch when there are more than 1 holds being placed. I was thinking it would be nice that if you changed 'Pickup at' al the lower 'Pickup location' would also change to what you choose? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Lucas Gass from comment #2)
This patch sets the 'Pickup location' according to the DefaultHoldPickupLocation but not the 'Pickup at' higher up because I was unsure how you'd set that to the item's home/holding branch when there are more than 1 holds being placed.
That's why I specified "if DefaultHoldPickupLocation is set to logged in library". It should be the same for all holds in that case. The client who reported this to me is a one-branch library and they wanted to avoid having to choose a branch there (I also filed bug 36870 about that). But I figured if their pref is set to logged in library, it would be another way to avoid the extra clicks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166857|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 166905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166905&action=edit Bug 36871: Honor DefaultHoldPickupLocation when placing holds for multiple items at once To test: 0. Make sure the DefaultHoldPickupLocation system preference is set to logged in library. 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) --> "Pickup location" is empty and the staff member must select the library 5. APPLY PATCH and restart_all 6. Try again, the default should be set according to the DefaultHoldPickupLocation system preference Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Lucas, I hadn't realized we had to fill either the top or the bottom ones. It works this way and removes the extra click. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DefaultHoldPickupLocation = |Honor |logged in library on |DefaultHoldPickupLocation |multi-holds |when placing holds for | |multiple items at once -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166905|0 |1 is obsolete| | --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171263&action=edit Bug 36871: Honor DefaultHoldPickupLocation when placing holds for multiple items at once To test: 0. Make sure the DefaultHoldPickupLocation system preference is set to logged in library. 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) --> "Pickup location" is empty and the staff member must select the library 5. APPLY PATCH and restart_all 6. Try again, the default should be set according to the DefaultHoldPickupLocation system preference Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I seem to remember a discussion about this when we last touched this code. I think the problem was that the DefaultHoldPickupLocation could be an invalid choice for all or some of the records when placing multiple holds. Has thie been tested or taken into account here? (Failed QA for the question) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- But isn't this handled by $biblio->pickup_locations ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Paul Derscheid from comment #8)
But isn't this handled by $biblio->pickup_locations ?
Queue is a bit full, so not time for extensive testing. Would be good to verify :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 --- Comment #10 from Kristi Krueger <kkrueger@cuyahogalibrary.org> --- Our staff have recently noticed this and would be happy to see a fix. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org