https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- We tested old script j2a.pl and seems this problem already existed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 109229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109229&action=edit Bug 26307: Reveal problem in unit test for too_old Logic : ======= Looking at Koha::Patron->get_age : At birthday aniversary, patron has aged 1 year more. For example : - today is 2020-08-27 - patron with date of birth 2000-08-28 is 19 year old - patron with date of birth 2000-08-27 is 20 year old Looking at Koha::Patron->is_valid_age : Category min and max limits are inclusive. For example max=17 means : - patron having 17 years old is valid - patron having 18 years old is not valid Test suite : =========== Changes child3 to have 18 years tomorrow. Adds a child4 with 18 years today. Test plan : Run prove t/db_dependent/Patrons.t See it fails on 'One under age patron in child category' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 109230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109230&action=edit Bug 26307: Fix misc/cronjobs/update_patrons_category.pl --too_old acts a year too early misc/cronjobs/update_patrons_category.pl --too_old must change category when the age of the patron is greater than (exclusive) limit age of the category. Actually it changes a year too early : he goes to a min 18 years category having reached 17 years. Patch also changes the compare to 'lower and equal' and uses date without time => so that update occures at birthday aniversary day See logic in previous patch. And code in Koha::Patron : get_age() and is_valid_age. Test plan : 1) Create a child patron category 'C' with upper limit 17 years 2) Create an adult patron category 'A' 3) Create a patron in child category with date of birth = today - 18 years + 1 day 4) Check patron as age : 17 years 11 months 5) Without patch run : misc/cronjobs/update_patrons_category.pl -f=ENF -t=ADULT --too_old -v => You see the patron 6) apply patch 7) Re-run 5) => You dont see the patron 8) Update database to change patron date of birth = today - 18 years mysql > update borrowers set dateofbirth='YYYY-MM-DD' where borrowernumber=XXX; 9) Run : misc/cronjobs/update_patrons_category.pl -f=ENF -t=ADULT --too_old -v --confirm 10) Check patron category is now 'A' 11) Check you dont see message "Patron's age is incorrect for their category" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 109232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109232&action=edit Bug 26307: Use same syntax in --too_young In too_young use dt->strftime("%Y-%m-%d") like in too_old. This does not change the behavior. Test plan : Run prove t/db_dependent/Patrons.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- I don't think this is a bug, or rather, I don't know I see your point, if you have categories: Child Upper Age Limit 17 Adult Minimum Age 18 You don't cross until you are 18, however, you can also read that there is a gap between 17 and 18 The way Koha has always worked you have: Child Upper Age Limit 18 Adult Minimum Age 18 Now there is no gap and you switch at 18 I think changing a long standing behaviour will affect many people, and that makes me nervous. I know that I have helped libraries set this up in the way that works. I think instead we need to clarify the explanation of the 'Limit' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Fridolin SOMERS from comment #7)

(In reply to Nick Clemens from comment #6)

...

I don't think this is a bug, or rather, I don't know

I see your point, if you have categories: Child Upper Age Limit 17 Adult Minimum Age 18

You don't cross until you are 18, however, you can also read that there is a gap between 17 and 18

The way Koha has always worked you have: Child Upper Age Limit 18 Adult Minimum Age 18

Now there is no gap and you switch at 18

I think changing a long standing behaviour will affect many people, and that makes me nervous. I know that I have helped libraries set this up in the way that works.

I think instead we need to clarify the explanation of the 'Limit'

OK this is the other solution ;)

In your example, a 18 years old patron can be in Child or Adult category without breaking the limits ?

For you limits are inclusive right ?

I think the lower limit is inclusive, the upper is exclusive: At least X years old to Less than X years old However, in testing, it was found that the scripts work on way, and the interface another. Try to enter a patron into a category from 5-17. At 17 and 1 day they can still be entered, at 18 they are prohibited. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- After thinking about it for a bit, I think the current behaviour makes sense. If CHILD has an upper limit of 18, it means the patron should change category on the day she turns 18. And ADULT has a lower limit of 18, because the day the patron turns 18 they should be moved to this category. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27554 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27554 [Bug 27554] Wrong test for Koha::Patrons->update_category_to child to adult -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Changind |Changing patron category |update_patrons_category |should check age limits |should check age limits | -- You are receiving this mail because: You are watching all bug changes.