[Bug 16430] New: Mainpage.pl dies if library is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 Bug ID: 16430 Summary: Mainpage.pl dies if library is not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On a fresh install of Koha, logging in I was met with: Invalid dateformat parameter () at /home/vagrant/kohaclone/Koha/DateUtils.pm line 112. It appears that if the library is not set, you get this message on mainpage.pl. Needless to say, this adds difficulty in setting up a fresh install of Koha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51136&action=edit Bug 16430 - Mainpage.pl dies if library is not set On a fresh install of Koha, logging in I was met with: Invalid dateformat parameter () at /home/vagrant/kohaclone/Koha/DateUtils.pm line 112. It appears that if the library is not set, you get this message on mainpage.pl. Needless to say, this adds difficulty in setting up a fresh install of Koha! Test Plan: 1) Check out master, start with a fresh empty database 2) Go through the installer, log in with the db user for the first time 3) Note the error 4) Apply this patch 5) Refresh the page, the error should be gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51136|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51137&action=edit Bug 16430 - Mainpage.pl dies if library is not set On a fresh install of Koha, logging in I was met with: Invalid dateformat parameter () at /home/vagrant/kohaclone/Koha/DateUtils.pm line 112. It appears that if the library is not set, you get this message on mainpage.pl. Needless to say, this adds difficulty in setting up a fresh install of Koha! Test Plan: 1) Check out master, start with a fresh empty database 2) Go through the installer, install all default data, log in with the db user for the first time 3) Note the error 4) Apply this patch 5) Refresh the page, the error should be gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- On further testing, I think this may be a much deeper problem than this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- The root case is a change in dt_from_string: $date_format = C4::Context->preference('dateformat') unless $date_format; This line means that if the caller does not pass a format, the native preferred format is assumed. When not logged in, $date_format will be empty and cause an error. There are also many calls to dt_from_string where no format is passed which will cause other errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|kyle@bywatersolutions.com |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd keep the die, to catch next issues of the same kind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate, did you fix the sysprefs.sql file before? See bug 16418 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16430 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This one was invalid, it was caused by a syntax error in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org