[Bug 10226] New: suspended holds still show not available
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Bug ID: 10226 Summary: suspended holds still show not available Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com CC: gmcharlt@gmail.com See here: http://screencast.com/t/4ZfelnlJ If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31183&action=edit Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31183|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31185&action=edit Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31185|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 31217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31217&action=edit Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, could you back this up by a regression test please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31217|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31475&action=edit [PASSED QA] Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
Hi Kyle, could you back this up by a regression test please?
I started to QA this one and didn't see you did it! I was writing unit tests when I saw your comment. They are coming... Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31475|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31504&action=edit Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31505&action=edit Bug 10226: Add unit tests for GetReservesFromItemnumber Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org