[Bug 21263] New: Pickup library not set correctly when using Default holds policy by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Bug ID: 21263 Summary: Pickup library not set correctly when using Default holds policy by item type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Not sure if this is a bug or just me misunderstanding the options - Make sure OPACAllowUserToChooseBranch is set to don't allow - Make sure you have two branches A and B - Have one item whose homebranch is B - Have one user whose homebranch is A - Make sure the circulation rules allow the user to reserve the item's item type 1. Go to Administration > Circulation and fines rules 2. Create a Default holds policy by item type for that item type - Item type = item's item type - Hold policy = From any library - Hold pickup library branch = item's home library - Return policy = item returns home 3. Go to the OPAC and log in with the user's credentials 4. Search for the item 5. Click on "Place hold" 6. Confirm hold 7. In the user's file on the OPAC and check the reservation's pickup library What I understand : - Hold policy = From any library: Users from any library can reserve this item type - Hold pickup library branch = item's home library: the pickup library must be the item's homebranch (in this case, B) - Return policy = item returns home: upon return, the items is transferred to its homebranch Therefore, the pickup library in the case above should be B, but it is automatically set to A. P.S. note that I have item-level_itypes set to specific item, and Item level holds set to don't allow. I feel like in this case it should maybe fall back to the record-level item type? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 --- Comment #1 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 84846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84846&action=edit Bug 21263: Pickup library not set correctly when using Default holds policy In the case of a specific item hold, it can only be fulfilled if the pickup library matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch is set to don't allow, the pickup library should correspond to the policy. In case of hold that does not specify an item, the homebranch or holdingbranch can't be determined at this time, so the pickup library still defaults to the homebranch of the borrower. Same if there is no policy or it states 'any'. To test: - Make sure OPACAllowUserToChooseBranch is set to don't allow - Make sure you have two branches A and B - Have one item whose homebranch is B - Have one user whose homebranch is A - Make sure the circulation rules allow the user to reserve the item's item type 1. Go to Administration > Circulation and fines rules 2. Create a Default holds policy by item type for that item type - Item type = item's item type - Hold policy = From any library - Hold pickup library match = item's home library - Return policy = item returns home 3. Go to the OPAC and log in with the user's credentials 4. Search for the item 5. Click on "Place hold" 6. Select a specific item and confirm hold 7. In the user's file on the OPAC and check the reservation's pickup library. It should be the item's homebranch You can then repeat the steps for 'item's holding library' or 'any library' as the Hold pickup library match. It should also work the same way if there is no 'Default holds policy by item type' for this item type but a 'Default checkout, hold and return policy' set. Finally, check that placing a hold without selecting a specific item still defaults the pickup library to the borrower's homebranch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |maryse.simard@inlibro.com |ity.org | CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84846|0 |1 is obsolete| | --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86335&action=edit Bug 21263: Pickup library not set correctly when using Default holds policy In the case of a specific item hold, it can only be fulfilled if the pickup library matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch is set to don't allow, the pickup library should correspond to the policy. In case of hold that does not specify an item, the homebranch or holdingbranch can't be determined at this time, so the pickup library still defaults to the homebranch of the borrower. Same if there is no policy or it states 'any'. To test: - Make sure OPACAllowUserToChooseBranch is set to don't allow - Make sure you have two branches A and B - Have one item whose homebranch is B - Have one user whose homebranch is A - Make sure the circulation rules allow the user to reserve the item's item type 1. Go to Administration > Circulation and fines rules 2. Create a Default holds policy by item type for that item type - Item type = item's item type - Hold policy = From any library - Hold pickup library match = item's home library - Return policy = item returns home 3. Go to the OPAC and log in with the user's credentials 4. Search for the item 5. Click on "Place hold" 6. Select a specific item and confirm hold 7. In the user's file on the OPAC and check the reservation's pickup library. It should be the item's homebranch You can then repeat the steps for 'item's holding library' or 'any library' as the Hold pickup library match. It should also work the same way if there is no 'Default holds policy by item type' for this item type but a 'Default checkout, hold and return policy' set. Finally, check that placing a hold without selecting a specific item still defaults the pickup library to the borrower's homebranch. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86335|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 87582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87582&action=edit Bug 21263: Pickup library not set correctly when using Default holds policy In the case of a specific item hold, it can only be fulfilled if the pickup library matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch is set to don't allow, the pickup library should correspond to the policy. In case of hold that does not specify an item, the homebranch or holdingbranch can't be determined at this time, so the pickup library still defaults to the homebranch of the borrower. Same if there is no policy or it states 'any'. To test: - Make sure OPACAllowUserToChooseBranch is set to don't allow - Make sure you have two branches A and B - Have one item whose homebranch is B - Have one user whose homebranch is A - Make sure the circulation rules allow the user to reserve the item's item type 1. Go to Administration > Circulation and fines rules 2. Create a Default holds policy by item type for that item type - Item type = item's item type - Hold policy = From any library - Hold pickup library match = item's home library - Return policy = item returns home 3. Go to the OPAC and log in with the user's credentials 4. Search for the item 5. Click on "Place hold" 6. Select a specific item and confirm hold 7. In the user's file on the OPAC and check the reservation's pickup library. It should be the item's homebranch You can then repeat the steps for 'item's holding library' or 'any library' as the Hold pickup library match. It should also work the same way if there is no 'Default holds policy by item type' for this item type but a 'Default checkout, hold and return policy' set. Finally, check that placing a hold without selecting a specific item still defaults the pickup library to the borrower's homebranch. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I sort of wish this was within the Modules rather than at the controller/script side and as such I could request tests. We could test it via selenium integration tests to prevent regression but that feels like a fairly big ask here. As I can't find any regressions and it appears to work as expected I'm going to PQA.. but I'd love to see a more thorough treatment and unit tests down the line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Klas Blomberg <klas.blomberg@skovde.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klas.blomberg@skovde.se --- Comment #8 from Klas Blomberg <klas.blomberg@skovde.se> --- I think this patch needs a small adjustment to be more generally useful. We have OPACAllowUserToChooseBranch set to allow as we're a consortium where users frequently use other libraries than their homebranch Sometimes we want to use the combination Hold policy from any library in combination with Hold pickup library match item's home library Default holds policy by item type is still not respected for this combination when this patch is applied Would it work even for us if we delete this condition? if ( ! C4::Context->preference("OPACAllowUserToChooseBranch") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33074 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33074 [Bug 33074] ReservesControlBranch not taken into account in opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org