[Bug 9773] New: Replace YUI AJAX calls in cataloging plugins with jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Bug ID: 9773 Summary: Replace YUI AJAX calls in cataloging plugins with jQuery Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org CC: m.de.rooy@rijksmuseum.nl There are calls in a few cataloging plugins to YUI AJAX functions. These can be replaced with jQuery code. cataloguing/value_builder/callnumber.pl cataloguing/value_builder/callnumber-KU.pl cataloguing/value_builder/stocknumberam123.pl cataloguing/value_builder/unimarc_field_010.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15989&action=edit Bug 9773 - Replace YUI AJAX calls in cataloging plugins with jQuery Several cataloging plugins make some simple AJAX GET calls via the YUI AJAX feature. This code can be easily converted to jQuery. To test, link each plugin to the relelvant field by editing your MARC stucture. Confirm that functionality is unchanged. For callnumber.pl and callnumber-KU.pl, test by linking to 952o. callnumber.pl is triggered on blur of (when you focus on and click away from) the 952o entry field. callnumber-KU.pl is triggered by clicking the "..." link. stocknumberam123.pl should be linked to 952i. If your data doesn't already have information stored for inventory number, modify at least one record to add one. The plugin is triggered on blur of the 952i field. It should increment the highest value inventory number stored in your system. unimarc_field_010.pl is UNIMARC-specific, so I'm guessing about its functionality. I tested it by linking the plugin to MARC21 field 020a. The plugin is triggered on blur of the affected field (020a in my test). You can confirm that the plugin returns valid data by using a tool like Firebug to view the XHR response. Or if you're not using UNIMARC you can hack the plugin to update a different field instead (line 57, /^tag_210_subfield_c/ ). I tried "245_subfield_c" instead of "210c_subfield_c." Nonsensical, but useful for testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9779 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Switching this from enhancement to bug since YUI JS dependencies need to go away. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15989|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 18444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18444&action=edit Bug 9773 - Replace YUI AJAX calls in cataloging plugins with jQuery Several cataloging plugins make some simple AJAX GET calls via the YUI AJAX feature. This code can be easily converted to jQuery. To test, link each plugin to the relelvant field by editing your MARC stucture. Confirm that functionality is unchanged. For callnumber.pl and callnumber-KU.pl, test by linking to 952o. callnumber.pl is triggered on blur of (when you focus on and click away from) the 952o entry field. callnumber-KU.pl is triggered by clicking the "..." link. stocknumberam123.pl should be linked to 952i. If your data doesn't already have information stored for inventory number, modify at least one record to add one. The plugin is triggered on blur of the 952i field. It should increment the highest value inventory number stored in your system. unimarc_field_010.pl is UNIMARC-specific, so I'm guessing about its functionality. I tested it by linking the plugin to MARC21 field 020a. The plugin is triggered on blur of the affected field (020a in my test). You can confirm that the plugin returns valid data by using a tool like Firebug to view the XHR response. Or if you're not using UNIMARC you can hack the plugin to update a different field instead (line 57, /^tag_210_subfield_c/ ). I tried "245_subfield_c" instead of "210c_subfield_c." Nonsensical, but useful for testing. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Tried the 3 MARC21 plugins. Did not try the Unimarc one, but it's exactly the same code change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch replaces the YUI AJAX stuff with jQuery. It is a more readable and adds a new step to get rid of YUI. There is no more occurrence of 'YAHOO' in the cataloguing/value_builder directory. I tested the unimarc plugin and it works like as before. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18444|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18453&action=edit Bug 9773 - Replace YUI AJAX calls in cataloging plugins with jQuery Several cataloging plugins make some simple AJAX GET calls via the YUI AJAX feature. This code can be easily converted to jQuery. To test, link each plugin to the relelvant field by editing your MARC stucture. Confirm that functionality is unchanged. For callnumber.pl and callnumber-KU.pl, test by linking to 952o. callnumber.pl is triggered on blur of (when you focus on and click away from) the 952o entry field. callnumber-KU.pl is triggered by clicking the "..." link. stocknumberam123.pl should be linked to 952i. If your data doesn't already have information stored for inventory number, modify at least one record to add one. The plugin is triggered on blur of the 952i field. It should increment the highest value inventory number stored in your system. unimarc_field_010.pl is UNIMARC-specific, so I'm guessing about its functionality. I tested it by linking the plugin to MARC21 field 020a. The plugin is triggered on blur of the affected field (020a in my test). You can confirm that the plugin returns valid data by using a tool like Firebug to view the XHR response. Or if you're not using UNIMARC you can hack the plugin to update a different field instead (line 57, /^tag_210_subfield_c/ ). I tried "245_subfield_c" instead of "210c_subfield_c." Nonsensical, but useful for testing. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Tried the 3 MARC21 plugins. Did not try the Unimarc one, but it's exactly the same code change. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org