[Bug 33030] New: Add standardized subroutine for processing Template Toolkit syntax outside of notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Bug ID: 33030 Summary: Add standardized subroutine for processing Template Toolkit syntax outside of notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Koha has evolved to use Template Toolkit for many uses outside of generating slips and notices for patrons. Historically, each of these areas processed template toolkit in a slightly different way. We should add a module to allow Template Toolkit syntax to be processed in a standard and generic way such that all non-notice TT syntax is handled and processed the consistently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 147085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147085&action=edit Bug 33030: Add standardized subroutine for processing Template Toolkit syntax outside of notices Koha has evolved to use Template Toolkit for many uses outside of generating slips and notices for patrons. Historically, each of these areas processed template toolkit in a slightly different way. We should add a module to allow Template Toolkit syntax to be processed in a standard and generic way such that all non-notice TT syntax is handled and processed the consistently. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Letters/TemplateToolkit.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33041 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33041 [Bug 33041] Use process_tt in C4::Serial::NewIssue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33043 [Bug 33043] Use process_tt in SIP modules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33045 [Bug 33045] Use process_tt in C4::Record::marcrecord2csv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33046 [Bug 33046] Use process_tt in C4::Reports::Guided::EmailReport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147085|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 147182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147182&action=edit Bug 33030: Add standardized subroutine for processing Template Toolkit syntax outside of notices Koha has evolved to use Template Toolkit for many uses outside of generating slips and notices for patrons. Historically, each of these areas processed template toolkit in a slightly different way. We should add a module to allow Template Toolkit syntax to be processed in a standard and generic way such that all non-notice TT syntax is handled and processed the consistently. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148076&action=edit Bug 33030: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #4 from David Nind <david@davidnind.com> --- The tests currently fail: prove t/db_dependent/Koha/Items.t t/db_dependent/Koha/Items.t .. 6/16 # Looks like you planned 9 tests but ran 4. t/db_dependent/Koha/Items.t .. 15/16 # Failed test 'search_ordered' # at t/db_dependent/Koha/Items.t line 1904. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'published_on_template' in 'field list' at /kohadevbox/koha/t/lib/TestBuilder.pm line 384 # Looks like your test exited with 11 just after 15. t/db_dependent/Koha/Items.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 2/16 subtests Test Summary Report ------------------- t/db_dependent/Koha/Items.t (Wstat: 2816 Tests: 15 Failed: 1) Failed test: 15 Non-zero exit status: 11 Parse errors: Bad plan. You planned 16 tests but ran 15. Files=1, Tests=15, 5 wallclock secs ( 0.04 usr 0.00 sys + 3.69 cusr 0.58 csys = 4.31 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to David Nind from comment #4)
The tests currently fail:
prove t/db_dependent/Koha/Items.t
They are passing for me! Did you apply the dependency (Bug 33039) beforehand and run updatedatabase.pl? I get your error if I have applied both bugs but don't run updatedatabase.pl before running the unit tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147182|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 150511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150511&action=edit Bug 33030: Add standardized subroutine for processing Template Toolkit syntax outside of notices Koha has evolved to use Template Toolkit for many uses outside of generating slips and notices for patrons. Historically, each of these areas processed template toolkit in a slightly different way. We should add a module to allow Template Toolkit syntax to be processed in a standard and generic way such that all non-notice TT syntax is handled and processed the consistently. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Items.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148076|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 150512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150512&action=edit Bug 33030: Add unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Kyle M Hall from comment #5)
(In reply to David Nind from comment #4)
The tests currently fail:
prove t/db_dependent/Koha/Items.t
They are passing for me! Did you apply the dependency (Bug 33039) beforehand and run updatedatabase.pl? I get your error if I have applied both bugs but don't run updatedatabase.pl before running the unit tests.
It works with the updatedatabase - now signed off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> ---
It works with the updatedatabase - now signed off!
Thanks David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 [Bug 34136] Add ability to render a report using a notice template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- $processed = process_tt($template, $vars); Process the given Template Toolkit string, passing the given hashref of vars to the template, returning the processed string. It is written correctly. But when I see $template, I still think of a file.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150511|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153142&action=edit Bug 33030: Add standardized subroutine for processing Template Toolkit syntax outside of notices Koha has evolved to use Template Toolkit for many uses outside of generating slips and notices for patrons. Historically, each of these areas processed template toolkit in a slightly different way. We should add a module to allow Template Toolkit syntax to be processed in a standard and generic way such that all non-notice TT syntax is handled and processed the consistently. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Items.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150512|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153143&action=edit Bug 33030: Add unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can we stop with "Util" in package names please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Bug 33030 depends on bug 33039, which changed state. Bug 33039 Summary: Add ability to specify a template for serial subscription "Published on (text)" field https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #14)
Can we stop with "Util" in package names please?
I thought we did have a code guideline outlawing it but apparently we don't. Worth adding one for it I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Holding off on backport here thinking we may want to change the module name ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41902 [Bug 41902] Allow configuration of bibliographic information to be shown on new record duplicate check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33030 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42346 [Bug 42346] Add per-language template snippet system for translatable Template Toolkit sysprefs -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org