[Bug 7868] New: Warnings in logs for search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 Priority: P5 - low Change sponsored?: --- Bug ID: 7868 Assignee: adrien.saurat@biblibre.com Summary: Warnings in logs for search.pl QA Contact: koha.sekjal@gmail.com Severity: minor Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Searching Product: Koha When doing a search from the intranet, we get warnings in the logs like : Argument "" isn't numeric in numeric gt (>) at /home/asaurat/workspace/versions/community/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt line 75., referer: http://admin.community.localhost/cgi-bin/koha/catalogue/search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&sort_by=relevancea -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8757&action=edit proposed patch #1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8758&action=edit Amended patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8758|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 8758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8758 Amended patch Wrong file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8759&action=edit Amended patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7786 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8760&action=edit Followup for opac side Makes the same change in opac template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- This report fixes bug introduced by 7786 not checking if addbarshelvesloop or addpubshelvesloop were actually defined. Patch for staff and a patch for opac. I amended the patch of Adrien in order to cover the situation that addbarshelves does not exist but addpubshelves does exist. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8759|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8763&action=edit Amended patch Second correction of wrong file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |Virtual Shelves -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8757|0 |1 is obsolete| | Attachment #8760|0 |1 is obsolete| | --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 8764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8764&action=edit Followup for opac Tested both patches in opac results and staff results by removing all private lists. Without patches warnings in opac and staff. With patches no warnings in opac and staff. Status to Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Virtual Shelves |Searching --- Comment #9 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Didn't notice the OPAC impact, thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- Both patches simply add a check for the existence of the variable before doing a comparison on it. Marking Passed QA for both. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7868 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org