[Bug 9425] New: Template plugins are missing utf8 encoding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 Bug ID: 9425 Summary: Template plugins are missing utf8 encoding Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolyn.somers@biblibre.com Koha custom template plugins KohaAuthorisedValues and KohaBranchName are missing UTF-8 encoding. When they render a value with diacritical characters, those characters are replaced by a <?> sign. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 14697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14697&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Thank you for the detailed test plan. However, I cannot produce the problem. I see correct characters before and after the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #2)
Thank you for the detailed test plan. However, I cannot produce the problem. I see correct characters before and after the patch.
What string did you use ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Some nonsense constructions: Ļōŝŧ for a lost authorized value, and Čhauncey for a library name. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #4)
Some nonsense constructions: Ļōŝŧ for a lost authorized value, and Čhauncey for a library name. Can you test with a simple diacritic like 'losté' ?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14697|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15111&action=edit [SIGNED-OFF] Bug 9425: Template plugins are missing utf8 encoding Koha custom template plugins KohaAuthorisedValues and KohaBranchName are missing UTF-8 encoding. When they render a value with diacritical characters, those characters are replaced by a <?> sign. Test plan : For KohaAuthorisedValues : - Edit a value of LOST authorized values to have a description with a diacritical character - Edit a biblio to have an item using this authorized value in items.itemlost - Go to OPAC detail page of this biblio => Lost description must be correctly encoded For KohaBranchName : - Choose a serial subscription - Edit its branch to has a diacritical character in name - Go to subscription details : serials/subscription-detail.pl => Library name must be correctly encoded Signed-off-by: Owen Leonard <oleonard@myacpl.org> I was finally able to reproduce the problem in the OPAC, but still not in the staff client. However, since it's obvious the patch corrects problems in some situations and doesn't seem to have an adverse effect I'm signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Can reproduce your problem in staff, but have doubts on your solution. You encode the data while we are still processing in perl; this is theoretically incorrect but works since we still not activated utf8 in template processing. We should do that however; please see bug 6554. Bug 6554 (adjusted) will solve your problem; I am inclined to mark your solution non-future-proof. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8215 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Bug 8215 has introduced new template plugins with utf8 encoding. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl | --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #9)
Bug 8215 has introduced new template plugins with utf8 encoding.
With the revert of bug 6554 we are just messing around with encoding.. If you feel that this report now functions well, please set the status back to Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- This bug is obsolete due to Bug 8215 integration. *** This bug has been marked as a duplicate of bug 8215 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org