[Bug 33663] New: Don't hide Suggestions link in side navigation when suggestion preference is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Bug ID: 33663 Summary: Don't hide Suggestions link in side navigation when suggestion preference is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: michaela.sieber@kit.edu There is a mismatch in how we handle the suggestions link in the top navigation (More menu) an the sidebar navigation in the acquisition module. The link in the More menu is only dependent on the permissions of the user, the link in the sidebar also checks for the suggestion system preference. I believe the latter is not correct, as the suggestion pref explicitly mentions the OPAC: [Enable|Disable] purchase suggestions in the OPAC. Some libraries use other forms/tools to allow for users to make purchase suggestions. When suggestions are deactivated, they still want to have the feature available in the staff interface. We also now have permissions for suggestions, so we can still hide from staff using those if necessary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150950&action=edit Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled We don't want to depend on the pref for the staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150951&action=edit Bug 33663: Pass 'suggestion' to the OPAC templates only We don't need it for the staff interface. The previous patch is removing the only occurrence using it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 --- Comment #3 from Michaela Sieber <michaela.sieber@kit.edu> --- Test Plan: Go to system pref and disable 'suggestion' (disable purchase suggestions in the OPAC.) Go to Acquisition and recognize that the suggestions link in the sidebar navigation in the acquisition module does not appear any more. Apply Patch - Go to system pref and disable 'suggestion' - Go to Acquisition and recognize that the suggestions link in the sidebar navigation in the acquisition module exists - Sign Off :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150950|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 151502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151502&action=edit Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled We don't want to depend on the pref for the staff interface. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150951|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 151503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151503&action=edit Bug 33663: Pass 'suggestion' to the OPAC templates only We don't need it for the staff interface. The previous patch is removing the only occurrence using it. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151502|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 151600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151600&action=edit Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled We don't want to depend on the pref for the staff interface. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151503|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 151601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151601&action=edit Bug 33663: Pass 'suggestion' to the OPAC templates only We don't need it for the staff interface. The previous patch is removing the only occurrence using it. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.07 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33663 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org