http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|henridamien@koha-fr.org |amit.gupta@osslabs.biz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Is anyone working on this? This would be very handy. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|navya.vp@osslabs.biz |amit.gupta@osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #2 from Amit Gupta <amit.gupta@osslabs.biz> --- Created attachment 9982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9982&action=edit Acquistions duplicate search across orders, suggestions and catalog Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (early) QA Comments : 1/ The commit message notices "PATCH 3/3". Where are the 2 first commits ? I think this one is the unique one :) 2/ The indentation is 4 spaces to separate blocks. It is not the case in this patch (8 or 0 in several cases, the average is good but it is not what is expected :-) ). 3/ if ( cond ) {} else { //some instructions } should be replaced with unless ( cond ) { //some instructions } -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|amit.gupta@osslabs.biz |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|jonathan.druart@biblibre.co |amit.gupta@osslabs.biz |m | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | Attachment #11527|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 11532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11532&action=edit Bug 6813: Acquistions duplicate search across orders, suggestions and catalog To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | Attachment #11527|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 11533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11533&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 11534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11534&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11537|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11538|0 |1 is obsolete| | --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 11539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11539&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | Attachment #11527|0 |1 is obsolete| | --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 11541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11541&action=edit [SIGNED-OFF] Bug 6813: Acquistions duplicate search across orders, suggestions and catalog To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * the template does not respect HTML4 coding guidelines = there are UCfirst on every word, please switch to lowercase * have you tested on a large database. MySQL will not optimize SELECT ... FROM biblio WHERE title LIKE '%something%', and performances will be very poor. I think it should be specified on the home "duplicatesearch" page * the name "duplicate search" sounds strange to me. Shouldn't it be something like "multi-source search" or something like that ? (Search for duplicate ?) being not english native, I won't be affirmative, but Nicole, if you could confirm... * when you reach the page, you get a: Duplicate Search No Result that is irrelevant. failing QA (i'll accept this patch after feature freeze, no side effect risk, that's only new code) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Marc Véron <veron@veron.ch> --- I suppose the changes I made need a new signoff... Oh, and in my previous comment I mistaked with the wording, it is "Duplicate finder" (Google: 1'710'000) Marc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11542|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12715&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia@bywatersolutions.com Patch complexity|--- |Medium patch --- Comment #25 from Melia Meggs <melia@bywatersolutions.com> --- I applied all patches and followed the test plan. Duplicate Finder search works as advertised. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |paul.poulain@biblibre.com --- Comment #27 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * passes koha-qa.pl, except for a POD mistake revealed in C4/Suggestions.pm, I attach a follow-up fixing this problem * the patch work as expected, no side effect or any problem spotted. However, I won't pass QA this patch immediately because I've 2 questions = why is this tool in the acquisition module ? It is not specifically related to acquisition ? I think it's something that looks like the /cataloguing/addbooks.pl, that searches in the catalog and the reservoir. Shouldn't we replace the cataloguing/addbooks.pl by this new script (on which we would add a "reservoir" tab) ? Once the librarian has done his search, we could have, instead of just "New record" (to catalogate a new biblio), a "New record" and a "New suggestion" button. That would improve consistency imo. I won't fail QA for now, waiting for patch authors opinion. That will require more effort, but I think it's worth it, because it will both improve Koha functionally, usability, and code quality. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with Paul that this tool could be better integrated in existing workflows. Currently you can find duplicates, but you can't create orders or perform any other actions from the tool. But better integration would mean a lot more work/rewrite of the feature and it still might be useful for libraries as it is now (small steps...) Some things I noted: 1) FindBiblios only searches on biblio.title instead of using the search engine. 2) I am not sure about the permissions for the new feature: + flagsrequired => { acquisition => 'group_manage', acquisition => 'order_manage', acquisition => 'order_receive' }, I think as no critical information is shown in the search results we could maybe be a bit less strict here. Anyway a check for permissions should be added to the link in the navigation toolbar, so you can only see the duplicate finder if you are allowed to use it. 3) On the suggestion result list, the status is shown as in the database and not translatable. For example: ASKED 4) The patches are also missing unit tests for the new routines FindSuggestions and FindBiblios. As these patches are quite old (June 2012), I am not sure if 4) is a failed QA - leaving this decision to Jared. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|paul.poulain@biblibre.com |m.de.rooy@rijksmuseum.nl --- Comment #31 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14009|0 |1 is obsolete| | --- Comment #33 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 14009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14009 Bug 6813 follow-up, fix POD Obsoleting this one too. Failed, will amend the last patch for this edit. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12715|0 |1 is obsolete| | Attachment #12716|0 |1 is obsolete| | Attachment #13806|0 |1 is obsolete| | --- Comment #35 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15793&action=edit Bug 6813: Acquistions duplicate search across orders, suggestions and catalog To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15795&action=edit Bug 6813: Followup: Fix HTML4 coding, new wording, warning on empty search terms The aim of this followup is to fix issues from Comment #17: - HTML4 encoding UCfirst fixed - Warning regardig large databases - Added javascript with warning if search terms are empty - Removed not used fields from search form - Changed wording from "Duplicate search" (Google: 15'000) to "Find duplicates" (Google: 576'000) To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. Marc Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Paul Poulain <paul.poulain@biblibre.com> --- We don't have feedback from savitra or Amit, so failing QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kohapatch@gmail.com |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.