[Bug 30891] New: SMS provider shows on staff side even if SMS::Send driver is not set to "Email"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Bug ID: 30891 Summary: SMS provider shows on staff side even if SMS::Send driver is not set to "Email" Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It appears that in my original submission ( Bug 9021 ), I hid the SMS provider selector unless the SMS::Send driver was set to "Email", but only on the OPAC, not on the staff interface! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9021 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135589&action=edit Bug 30891: SMS provider shows on staff side even if SMS::Send driver is not set to "Email" It appears that in my original submission ( Bug 9021 ), I hid the SMS provider selector unless the SMS::Send driver was set to "Email", but only on the OPAC, not on the staff interface! Test Plan: 1) Set SMSSendDriver to anything except "Email" 2) Note the SMS Provider pulldown shows in the patron editor 3) Apply this patch 4) Reload the page, SMS Provider id should now be gone 5) Set SMSSendDriver to "Email" 6) Reload the page, SMS Provider should now be shown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135589|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 135612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135612&action=edit Bug 30891: SMS provider shows on staff side even if SMS::Send driver is not set to "Email" It appears that in my original submission ( Bug 9021 ), I hid the SMS provider selector unless the SMS::Send driver was set to "Email", but only on the OPAC, not on the staff interface! Test Plan: 1) Set SMSSendDriver to anything except "Email" 2) Note the SMS Provider pulldown shows in the patron editor 3) Apply this patch 4) Reload the page, SMS Provider id should now be gone 5) Set SMSSendDriver to "Email" 6) Reload the page, SMS Provider should now be shown Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135612|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 135721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135721&action=edit Bug 30891: SMS provider shows on staff side even if SMS::Send driver is not set to "Email" It appears that in my original submission ( Bug 9021 ), I hid the SMS provider selector unless the SMS::Send driver was set to "Email", but only on the OPAC, not on the staff interface! Test Plan: 1) Set SMSSendDriver to anything except "Email" 2) Note the SMS Provider pulldown shows in the patron editor 3) Apply this patch 4) Reload the page, SMS Provider id should now be gone 5) Set SMSSendDriver to "Email" 6) Reload the page, SMS Provider should now be shown Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 135722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135722&action=edit Bug 30891: (QA follow-up) Add check to patron details page Adds a similar check to the patron details shown when selecting the details tab in the patron account in the staff interface. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- This has the potential for libraries to lose sms_providers data. Can this please be backported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Noted for 21.05, hopefully it will be in 21.11 before the next and last release of 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org