[Bug 40171] New: ILL Patron Has No Email Address on File message upon "Send Notice To Patron"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Bug ID: 40171 Summary: ILL Patron Has No Email Address on File message upon "Send Notice To Patron" Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: tech@bethlehemlibraryct.org QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@openfifth.co.uk, tomascohen@gmail.com In using the ILL module, I noticed that when using the "Send Notice to Patron" button, I get no feedback as to whether the notification was sent successfully. Specifically, I had an ILL request from a patron with no email address on file. I assumed that an email was sent to the patron after clicking the button, but since he had no email address on file, he wasn't notified. It would be really helpful to have a message pop up saying "Patron has no email address on file. Please call XXX-XXX-XXXX to let them know that their ILL request has arrived." (or something similar) so that the staff member knows they need to call the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183383&action=edit Bug 40171: Fix tt param name Its tran_fail, not tran_error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183384&action=edit Bug 40171: Remove extraneous join() -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183385&action=edit Bug 40171: Return fail if no transports for patron Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule 2) Create a new ill request at: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick any type and any library, pick '42' for patron. This is the 'koha' user. 4) Create the request, click 'Send notice to patron'. Pick any template. Notice nothing is shown on the UI. 5) Apply patches. Repeat. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|24.11 |Main Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. With no email set for a patron, I now get a message in a yellow background "The requested notice was NOT queued for delivery by email, SMS". 2. However, with a valid email address and a working SMTP server (the patron welcome message is sent after processing the message queue), I still get the same message - that is, the notice is not queued. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183383|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183593&action=edit Bug 40171: Fix tt param name Its tran_fail, not tran_error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183384|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183594&action=edit Bug 40171: Remove extraneous join() -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183385|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183595&action=edit Bug 40171: Return fail if no transports for patron Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule 2) Create a new ill request at: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick any type and any library, pick '42' for patron. This is the 'koha' user. 4) Create the request, click 'Send notice to patron'. Pick any template. Notice nothing is shown on the UI. 5) Apply patches. Repeat. Notice you get the message: "The requested notice was NOT queued for delivery by email, SMS". 6) Edit the 'koha' patron and tick the following boxes on 'Patron messaging preferences': - Interlibrary loan ready - Interlibrary loan unavailable 7) Go back to the request and click 'Send notice to patron' and pick any option again. Notice now you get a success message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to David Nind from comment #4)
2. However, with a valid email address and a working SMTP server (the patron welcome message is sent after processing the message queue), I still get the same message - that is, the notice is not queued.
Thank you David, I missed some steps on my original test plan: 6) Edit the 'koha' patron and tick the following boxes on 'Patron messaging preferences': - Interlibrary loan ready - Interlibrary loan unavailable 7) Go back to the request and click 'Send notice to patron' and pick any option again. Notice now you get a success message. Can you please give it another go when possible? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183593|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 183627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183627&action=edit Bug 40171: Fix tt param name Its tran_fail, not tran_error. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183594|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 183628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183628&action=edit Bug 40171: Remove extraneous join() Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183595|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 183629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183629&action=edit Bug 40171: Return fail if no transports for patron Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule 2) Create a new ill request at: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick any type and any library, pick '42' for patron. This is the 'koha' user. 4) Create the request, click 'Send notice to patron'. Pick any template. Notice nothing is shown on the UI. 5) Apply patches. Repeat. Notice you get the message: "The requested notice was NOT queued for delivery by email, SMS". 6) Edit the 'koha' patron and tick the following boxes on 'Patron messaging preferences': - Interlibrary loan ready - Interlibrary loan unavailable 7) Go back to the request and click 'Send notice to patron' and pick any option again. Notice now you get a success message. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183627|0 |1 is obsolete| | --- Comment #12 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 184157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184157&action=edit Bug 40171: Fix tt param name Its tran_fail, not tran_error. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183628|0 |1 is obsolete| | --- Comment #13 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 184158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184158&action=edit Bug 40171: Remove extraneous join() Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183629|0 |1 is obsolete| | --- Comment #14 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 184159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184159&action=edit Bug 40171: Return fail if no transports for patron Test plan, k-t-d, don't apply patches yet: 1) Enable ILLModule 2) Create a new ill request at: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Pick any type and any library, pick '42' for patron. This is the 'koha' user. 4) Create the request, click 'Send notice to patron'. Pick any template. Notice nothing is shown on the UI. 5) Apply patches. Repeat. Notice you get the message: "The requested notice was NOT queued for delivery by email, SMS". 6) Edit the 'koha' patron and tick the following boxes on 'Patron messaging preferences': - Interlibrary loan ready - Interlibrary loan unavailable 7) Go back to the request and click 'Send notice to patron' and pick any option again. Notice now you get a success message. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- The changes to the pm file are not covered by tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184186&action=edit Bug 40171: Add tests prove t/db_dependent/Koha/ILL/Requests.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #16)
The changes to the pm file are not covered by tests.
Patch submitted. Added 'additional_work_needed' keyword to alert Lucas of this follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 --- Comment #19 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Pedro Amorim from comment #18)
(In reply to Jonathan Druart from comment #16)
The changes to the pm file are not covered by tests.
Patch submitted. Added 'additional_work_needed' keyword to alert Lucas of this follow-up.
OK I wait for backport on 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |martin.renvoize@openfifth.c | |o.uk Text to go in the| |Staff members now receive release notes| |clear feedback when | |attempting to send ILL | |notices to patrons who have | |no email address on file or | |haven't configured their | |messaging preferences for | |interlibrary loan | |notifications. | | | |Previously, when clicking | |"Send notice to patron" for | |an ILL request, staff | |received no indication | |whether the notice was | |successfully queued for | |delivery. If the patron had | |no email address or hadn't | |opted in to ILL messaging | |preferences, the notice | |would silently fail to | |send, leaving staff unaware | |that the patron wasn't | |notified. | | | |With this enhancement: | |- A warning message now | |displays if the notice | |cannot be queued: "The | |requested notice was NOT | |queued for delivery by | |email, SMS" | |- A success message | |displays when the notice is | |successfully queued | |- Staff can immediately see | |when they need to contact | |the patron through | |alternative means (such as | |telephone) | | | |**For staff:** If you see | |the warning message, check | |the patron's record to | |ensure: | |1. They have a valid email | |address on file | |2. They have enabled ILL | |messaging preferences | |(Interlibrary loan ready / | |Interlibrary loan | |unavailable) in their | |patron messaging | |preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.11 released in| | --- Comment #22 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.11 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #23 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40171 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org