[Bug 33140] New: Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Bug ID: 33140 Summary: Use facet label value in mouseover title attribute of facet removal link Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org The mouseover text for the remove link displays the link value of the facet rather than its label. (In koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc). Logically, it is always the label value that should be displayed to the user so this should also be used for the title attribute. For instance for a custom boolean valued facet one do not want to see the text "remove the facet true" when hovering on the link. (See bug 33139.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 147773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147773&action=edit Bug 33140 Use facet label value for mouseover text on facet removal link -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #2 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Test plan: * Follow the test plan in bug 33139 but additionally add this patch * Observe the mouseover text when hovering over the facet removal button of the E-resource facet (without patch the text will be "remove facet true/false") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33139 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Andreas, This one also looks like a good patch but lacks the proper commit message: * Commit title does not start with 'Bug XXXXX: ' - 224750a113 If you can fix this I would be happy to sign-off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147773|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153927&action=edit Bug 33140: Use facet label value for mouseover text on facet removal link This patch updates the facets includes in both the staff interface and OPAC so that the title attribute on "remove" links uses the full name rather than the code of the facet. So, library name instead of branchcode, collection code description instead of authorized value code. To test, apply the patch and perform a search in the staff interface. - Click a facet in the left-hand sidebar which will return more than one result. - On the reloaded page there should be a link next to that facet: [X]. Hovering your mouse over it should show "Remove facet [facet name]" e.g. "Remove facet Centerville" instead of "Remove facet CPL" - Test on library facets, item type facets, and collection code facets. - Perform the same test in the OPAC. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I corrected the commit message and added the test plan. Everything worked as it should in my tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Assignee|koha-bugs@lists.koha-commun |andreas.jonsson@kreablo.se |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153927|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154056&action=edit Bug 33140: Use facet label value for mouseover text on facet removal link This patch updates the facets includes in both the staff interface and OPAC so that the title attribute on "remove" links uses the full name rather than the code of the facet. So, library name instead of branchcode, collection code description instead of authorized value code. To test, apply the patch and perform a search in the staff interface. - Click a facet in the left-hand sidebar which will return more than one result. - On the reloaded page there should be a link next to that facet: [X]. Hovering your mouse over it should show "Remove facet [facet name]" e.g. "Remove facet Centerville" instead of "Remove facet CPL" - Test on library facets, item type facets, and collection code facets. - Perform the same test in the OPAC. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org