[Bug 9172] New: Move TinyMCE library outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Bug ID: 9172 Summary: Move TinyMCE library outside of language-specific directory Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The TinyMCE library should be moved to intranet-tmpl/lib so that it doesn't have to be duplicated for each translation and so that the translation script won't have to parse it each time. Rather than move the existing library I propose that the old copy be removed an an upgraded version be added to intranet-tmpl/lib/tiny_mce. I also propose that we do not distribute the docs and examples directories, reducing further TinyMCE's overall footprint. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Oh, another proposed change: To create a configuration include in which to specify translatable strings just as we do with the DatePicker and calendar.inc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The patch for this bug is too large to upload (2.6MB), but there is a branch for it on my Gitorious repo (http://gitorious.org/koha-dev/koha-dev) called ps-bug-9172-tinymce-lib-path-2012-11-30 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- The branch has been rebased against current master to resolve conflicts. Here is the commit message since I can't attach the patch: Bug 9172 - Move TinyMCE library outside of language-specific directory This patch removes the TinyMCE library from its language-specific location and puts it in intranet-tmpl/lib. The most recent version of TinyMCE is used, and the files added have been limited to those required for proper functionality of the editor. Files omitted: documentation, examples, unused plugins. To test, visit each page which uses the TinyMCE editor: News editing (tools/koha-news.pl), library editing (admin/branches.pl), and online help editing (help/edithelp.pl). The editor should look and function as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- [SIGNED-OFF]Bug 9172 - Move TinyMCE library outside of language-specific directory Comment: Work as described. Koha complains about forbidden pattern (====), but is a false positive, just comments in function definition. Could be removed, ej #=================================== sub get_params { #=================================== Test 1) git clone git://gitorious.org/koha-dev/koha-dev.git kohaclone 2) git checkout -b bug_9172 origin/ps-bug-9172-tinymce-lib-path-2012-11-30 3) Editor works as usual in News, Help and Branch editing How to merge.. is not my problem :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)
[SIGNED-OFF]Bug 9172 - Move TinyMCE library outside of language-specific directory
Comment: Work as described. Koha complains about forbidden pattern (====), but is a false positive, just comments in function definition. Could be removed, ej #=================================== sub get_params { #===================================
QA comments... the patch looks good, and works perfectly just one change before passing QA, can we please replace or delete the above mentioned string, used for detecting merge conflicts in files ps: i think this patch is a really a bugfix, rather than enhancement :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9926 --- Comment #6 from Mason James <mtj@kohaaloha.com> ---
QA comments... the patch looks good, and works perfectly
just one change before passing QA, can we please replace or delete the above mentioned string, used for detecting merge conflicts in files
ps: i think this patch is a really a bugfix, rather than enhancement :)
also, this patch depends on 9926 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #5)
#=================================== sub get_params { #===================================
Since these lines are in a file which is part of the TinyMCE distribution I hesitate to modify them. I notice too that we have a couple of examples of that construction in existing Koha scripts: kohaclone/authorities/authorities.pl: 535 # ======================== 536 # MAIN 537: #========================= 538 my $input = new CGI; 539 my $z3950 = $input->param('z3950'); kohaclone/cataloguing/addbiblio.pl: 714 # ======================== 715 # MAIN 716: #========================= 717 my $input = new CGI; 718 my $error = $input->param('error'); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to comment #7)
Since these lines are in a file which is part of the TinyMCE distribution I hesitate to modify them. I notice too that we have a couple of examples of that construction in existing Koha scripts:
Sorry for my comment, as Owen points there are other files with "===" marks. I think that this may pass, but of course is up to the QA people and RM. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #7)
(In reply to comment #5)
#=================================== sub get_params { #===================================
Since these lines are in a file which is part of the TinyMCE distribution I hesitate to modify them.
yes, i agree :) so, now passing QA on this... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I will need the QAed branch for merging. Mason, could you make it available somewhere? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #10)
I will need the QAed branch for merging. Mason, could you make it available somewhere?
hmmm, using Owens repo/branch should still apply fine to master (from memory, i had one tiny merge conflict) http://gitorious.org/koha-dev/koha-dev branch is 'ps-bug-9172-tinymce-lib-path-2012-11-30' will that be OK? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #11)
(In reply to comment #10)
I will need the QAed branch for merging. Mason, could you make it available somewhere?
i have signed off on this patch, its available for merging here... https://github.com/KohaAloha/Koha-Dev/tree/bug_9172 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9172 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #14 from Robin Sheat <robin@catalyst.net.nz> --- fyi this patch seems to break package builds. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org