[Bug 7981] New: Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Priority: P5 - low Change sponsored?: --- Bug ID: 7981 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref QA Contact: koha.sekjal@gmail.com Severity: minor Classification: Unclassified OS: All Reporter: chrish@catalyst.net.nz Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha When returning a book it is said to require a transfer if the home branch is not the same as the current branch (even if HomeOrHoldingBranchReturn specifies it should be returned to the holding branch) Later on a message is generated in returns.pl if the first test was true, and this message respects HomeOrHoldingBranchReturn and will put the correct branch name into the message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@kul.oslo.k | |ommune.no --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Seems to me HomeOrHoldingBranchReturn SysPref is a residue or at least not any more in use. Circulation rules in 'Default checkout, hold and return policy' seems to be the preferred setting. At least they are honored in C4::Circulation. This also affects SIP transactions as returns gets no return branch. I will make a small patch to remove syspref HomeOrHoldingBranchReturn and make C4::Circulation::AddReturn return message about transfer branch on checkin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #2 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Actually, on second look, circ/returns.pl uses C4::Context->preference('HomeOrHoldingBranchReturn'); Others should probably decide, but there cannot be two conflicting return policies, and I believe C4::Circulation should be the preferred setting. C4::GetBranchItemRule returns noreturn|holdingbranch|homebranch and defaults to homebranch if no default circulation rule is set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #3 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 26723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26723&action=edit Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros@gmail | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12021 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26723|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27487&action=edit [SIGNED-OFF] Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 27487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27487 [SIGNED-OFF] Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref Review of attachment 27487: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7981&attachment=27487) ----------------------------------------------------------------- Quick code review: - patch should also delete HomeOrHoldingBranchReturn from sysprefs.sql - I think the updatedatabase message could note that we remove HomeOrHoldingBranchReturn in favor of the circulation rules - Is there an existing test for the return policies? ... and now... sleep. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27487|0 |1 is obsolete| | --- Comment #6 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 27950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27950&action=edit Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27950|0 |1 is obsolete| | --- Comment #7 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 27992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27992&action=edit Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase Darn... lost original commit message in previos push -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 27992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27992 Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref Review of attachment 27992: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7981&attachment=27992) ----------------------------------------------------------------- And some trailing spaces FAIL t/db_dependent/Circulation_Branch.t OK pod FAIL forbidden patterns forbidden pattern: trailing space char (line 319) forbidden pattern: trailing space char (line 311) forbidden pattern: trailing space char (line 323) forbidden pattern: trailing space char (line 327) forbidden pattern: trailing space char (line 315) Marked as Failed QA. ::: C4/Circulation.pm @@ +1976,3 @@
$messages->{'WasTransfered'} = 1; } else { + $messages->{'NeedsTransfer'} = $returnbranch;
Why don't you keep needstransfer = 1 ? You don't use this value later. ::: circ/returns.pl @@ +272,5 @@
title => $biblio->{'title'}, homebranch => $biblio->{'homebranch'}, + homebranchname => GetBranchName( $biblio->{'homebranch'} ), + returnbranch => $returnbranch, + returnbranchname => GetBranchName( $returnbranch ),
Please use the Branches TT plugin to get a branch name from its code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27992|0 |1 is obsolete| | --- Comment #9 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 28199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28199&action=edit Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #10 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> ---
Why don't you keep needstransfer = 1 ? You don't use this value later.
This is why it's blocking bug 12021. AddReturn has been modified to add transfer branch to $message. I don't see any better way to pass the transfer branch to the SIP controller. NeedsTransfer in returns.pl was modified accordingly to avvoid confusion only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #11 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Path doesnt apply against master also. The first like of the path should indicate what it does not reiterate the original bug report. Which if applied is irrelevant as the option gets removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Colin, Can you explain a bit what needs to be changed to move this forward? The patch applies for on master tonight. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #13 from Colin Campbell <colin.campbell@ptfs-europe.com> --- The subject line does not give an indication of what the patch does. That line should convey a summary of the change made by the patch. Its meant to give the user some indication in the git logs etc of what changes. The current line is not only uninformative but misleading in this resepect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #14 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- I see the objections. Perhaps should it be moved to a new bug? The patch deletes HomeOrHoldingBranchReturn syspref and makes the logics of C4::Circulation::GetBranchItemRule decide return policy, which makes more sense than a syspref. Also the return message for transfers is fixed to allow SIP2 returns to alert branch on transfers. I have no experience in this som suggestins welcome! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Benjamin and Colin, maybe it's a misunderstanding here - from Colin's last comment I think what needs to be changes is not the code, but the documentation of it in the patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #16 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #15)
Hi Benjamin and Colin, maybe it's a misunderstanding here - from Colin's last comment I think what needs to be changes is not the code, but the documentation of it in the patch?
Yes. The first line should be a succinct summary of what the patch changes. As such its useful for future developers and others viewing the history when merging, debugging or learning about the code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Colin, could you maybe suggest a possible wording? Maybe it will be clearer then. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #18 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #17)
Hi Colin, could you maybe suggest a possible wording? Maybe it will be clearer then.
Make the Subject line Bug 7981 Remove HomeOrHoldingBranchReturn syspref The rest of the commit message explains the implications well enough. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Transfer message when |Remove |returning doesn't properly |HomeOrHoldingBranchReturn |respect |syspref |HomeOrHoldingBranchReturn | |syspref | --- Comment #19 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- (In reply to Colin Campbell from comment #18)
(In reply to Katrin Fischer from comment #17)
Hi Colin, could you maybe suggest a possible wording? Maybe it will be clearer then.
Make the Subject line
Bug 7981 Remove HomeOrHoldingBranchReturn syspref
The rest of the commit message explains the implications well enough.
I'm quite happy with that, as it is what the patch basically does. I took the liberty of changing. The attachment should mayhaps be changed accordingly? For the record, the old subject line was: "Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28199|Bug-7981---Transfer-message |Bug-7981---Remove-HomeOrHol filename|-when-returning-doesnt-.pat |dingBranchReturn-syspref.pa |ch |tch Attachment #28199|Bug 7981 - Transfer message |Bug 7981 - Remove description|when returning doesn't |HomeOrHoldingBranchReturn |properly respect |syspref |HomeOrHoldingBranchReturn | |syspref | --- Comment #20 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Comment on attachment 28199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28199 Bug 7981 - Remove HomeOrHoldingBranchReturn syspref Renamed subject to better match what the patch does -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Conflict CONFLICT (content): Merge conflict in C4/Circulation.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #22 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 33455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33455&action=edit Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #23 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Resolved conflict in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33455|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33455|Bug-7981---Transfer-message |Bug 7981 - Remove filename|-when-returning-doesnt-.pat |HomeOrHoldingBranchReturn |ch |syspref Attachment #33455|1 |0 is obsolete| | --- Comment #24 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Comment on attachment 33455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33455 Bug 7981 - Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref Obsoleted wrong patch. fixed now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |mtompset@hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8836 --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- I'm moving this back to assigned, because I noticed some rotating collections variable was lost. This might not reflect that changes made in bug 8836. Please check, and either change to needs sign off if the changes are reflected OR fix and then change to needs sign off. This was just a quick eyeball. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28199|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28199|0 |1 is obsolete| | Attachment #33455|0 |1 is obsolete| | --- Comment #26 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 36615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36615&action=edit Bug 7981 - Remove HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Assignee|kyle.m.hall@gmail.com |benjamin.rokseth@kul.oslo.k | |ommune.no See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3536 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- HomeOrHoldingBranchReturn has been introduced by bug 3536. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36615|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37724&action=edit Bug 7981 - Remove HomeOrHoldingBranchReturn syspref Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37725&action=edit Bug 7981: Remove HomeOrHoldingBranchReturn syspref from C4::UsageStats Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37726&action=edit Bug 7981: Use The Branches TT plugin instead of GetBranchName Note that homebranchname is never used in the template. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- This should be highlighted in the release notes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some first notes - please fix! FAIL installer/data/mysql/updatedatabase.pl OK critic OK forbidden patterns OK pod FAIL valid Missing right curly or square bracket installer/data/mysql/updatedatabase.pl had compilation errors. syntax error OK t/db_dependent/Circulation_Branch.t OK critic OK forbidden patterns OK pod OK valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL forbidden patterns forbidden pattern: tab char (line 287) forbidden pattern: tab char (line 279) OK tt_valid OK valid_template OK installer/data/mysql/sysprefs.sql OK sysprefs_order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38151&action=edit Bug 7981: Follow-up - Fix qa script complaints - Fix updatedatabase, moving the update entry into the right spot - Fix some tabs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38174&action=edit Bug 7981 [QA Followup] - Rename TT vars -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37724|0 |1 is obsolete| | Attachment #37725|0 |1 is obsolete| | Attachment #37726|0 |1 is obsolete| | Attachment #38151|0 |1 is obsolete| | Attachment #38174|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38176&action=edit Bug 7981 - Remove HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38177&action=edit [SIGNED-OFF] Bug 7981: Remove HomeOrHoldingBranchReturn syspref from C4::UsageStats Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38178&action=edit [SIGNED-OFF] Bug 7981: Use The Branches TT plugin instead of GetBranchName Note that homebranchname is never used in the template. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38179&action=edit [SIGNED-OFF] Bug 7981: Follow-up - Fix qa script complaints - Fix updatedatabase, moving the update entry into the right spot - Fix some tabs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38180&action=edit [SIGNED-OFF] Bug 7981 [QA Followup] - Rename TT vars Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Attachment #38151|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38151|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38179|0 |1 is obsolete| | Attachment #38180|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38237&action=edit Bug 7981: Follow-up - Fix qa script complaints - Fix updatedatabase, moving the update entry into the right spot - Fix some tabs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #41 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38238&action=edit Bug 7981 [QA Followup] - Rename TT vars Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last 2 patches fix: Applying: Bug 7981: Follow-up - Fix qa script complaints fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38176|0 |1 is obsolete| | --- Comment #43 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 38241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38241&action=edit Bug 7981 - Remove HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #44 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 38242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38242&action=edit Bug 7981: Remove HomeOrHoldingBranchReturn syspref from C4::UsageStats Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #45 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 38243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38243&action=edit Bug 7981: Use The Branches TT plugin instead of GetBranchName Note that homebranchname is never used in the template. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38237|0 |1 is obsolete| | --- Comment #46 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 38244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38244&action=edit Bug 7981: Follow-up - Fix qa script complaints - Fix updatedatabase, moving the update entry into the right spot - Fix some tabs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38238|0 |1 is obsolete| | --- Comment #47 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 38245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38245&action=edit Bug 7981 [QA Followup] - Rename TT vars Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38177|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38178|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
From reading the code:
+ # do the return + ( $returned, $messages, $issueinformation, $borrower ) = + AddReturn( $barcode, $userenv_branch, $exemptfine, $dropboxmode, $return_date_override ); + I think we miss the dropboxdate here - Please check and fix. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Small follow-up needed... someone? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #50 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39504&action=edit Bug 7981: Reintroduce dropboxdate The parameter was lost in previous commit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38241|0 |1 is obsolete| | Attachment #38242|0 |1 is obsolete| | Attachment #38243|0 |1 is obsolete| | Attachment #38244|0 |1 is obsolete| | Attachment #38245|0 |1 is obsolete| | Attachment #39504|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39848&action=edit Bug 7981 - Remove HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #52 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39849&action=edit Bug 7981: Remove HomeOrHoldingBranchReturn syspref from C4::UsageStats Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #53 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39850&action=edit Bug 7981: Use The Branches TT plugin instead of GetBranchName Note that homebranchname is never used in the template. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #54 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39851&action=edit Bug 7981: Follow-up - Fix qa script complaints - Fix updatedatabase, moving the update entry into the right spot - Fix some tabs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #55 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39852&action=edit Bug 7981 [QA Followup] - Rename TT vars Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #56 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39853&action=edit Bug 7981: Reintroduce dropboxdate The parameter was lost in previous commit. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #57 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Benjamin and pals! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12021 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 39848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39848 Bug 7981 - Remove HomeOrHoldingBranchReturn syspref Review of attachment 39848: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7981&attachment=39848) ----------------------------------------------------------------- ::: circ/returns.pl @@ +265,5 @@
); }
+ # make sure return branch respects home branch circulation rules, default to homebranch + my $hbr = GetBranchItemRule($biblio->{'homebranch'}, $itemtype)->{'returnbranch'} || "homebranch";
I think there is a problem here. $itemtype is a hashref returned by C4::ItemType->get, but GetBranchItemRule expects a string. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #59 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Well spotted, Jonathan! Since it is already pushed to master, could you apply a patch? My env is a bit off at the moment. (silly excuse ;) Maybe this is the reason for the strange fault in print slip on transfer on http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14842 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 [Bug 14842] Wrong call to GetBranchItemRule in circ/returns.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Benjamin Rokseth from comment #59)
Well spotted, Jonathan! Since it is already pushed to master, could you apply a patch? My env is a bit off at the moment. (silly excuse ;)
Maybe this is the reason for the strange fault in print slip on transfer on http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043
See bug 14842. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #60)
Maybe this is the reason for the strange fault in print slip on transfer on http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043
I don't think so, 7981 is present in master only for 5 months. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org