[Bug 23111] New: Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Bug ID: 23111 Summary: Setting a custom framework as the default for cataloguing is not possible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: hayleymapley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- Currently, it is not possible to select a custom framework as the default, in situations where editing a record with no framework mapped, or importing a staged MARC file with no mapping. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #1 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 90550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90550&action=edit Bug 23111: Set custom bibliographic framework as default This patch adds a new system preference (DefaultBibliographicFramework). Using this a librarian can select the bibliographic framework code to set the the bibliographic framework that will be displayed as default when: * Importing batch of biblio records * Editing a biblio record with no mapped biblio framework Test plan: 1. Apply patch 2. Run ./updatedatabase.pl (in installer/data/mysql) from the Koha shell to implement db changes 3. Search for the syspref DefaultBibliographicFramework in Administration module 4. Notice the syspref has the value 'Default' 5. Locate and edit the record of a bibliographic record not mapped to a framework and notice 'Default' is ticked when you click on 'Settings' 6. Click 'Save' and confirm the frameworkcode of the bibliorecord is Default (stored in the database as empty). You can do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber>; 7. Import a batch of biblio records and notice that 'Default' is displayed as the framework to be used 8. Confirm the frameworkcode of one of the imported biblio records is default. Do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber of biblio imported in step 7>; 9. Select a different frameworkcode (such as Acquisitions) in the DefaultBibliographicFramework syspref 10. Repeat step 5 but notice the DefaultBibliographicFramework framework as shown as the framework 11. Confirm the biblio has the new frameworkcode. You can do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber>; 12. Repeat step 7 and notice the DefaultBibliographicFramework is shown as the framework to be used 13. Confirm the biblios imported in step 12 have the correct frameworkcode by running the following SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber of imported biblio in step 12>; Authored-by: Alex Buckley Sponsored-by: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This looks to be working great--and it's a great improvement. The QA tool is giving one warning though: FAIL Koha/BiblioFramework.pm OK critic OK forbidden patterns OK git manipulation FAIL pod *** ERROR: Apparent command =cut not preceded by blank line in file Koha/BiblioFramework.pm Also: Could we get the framework name to show in the system preference instead of just the code? I don't think it's a dealbreaker but it would be more user-friendly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 90587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90587&action=edit Bug 23111: (follow-up) Fix for QA test tool failure -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 90588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90588&action=edit Bug 23111: (follow-up) Fix for QA test tool failure Test plan: 1. Follow the test plan in the first commit 2. Run the qa test tool and notice that it no longer fails on the Koha/BiblioFramework.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #5 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 91039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91039&action=edit Bug 23111: Set custom bibliographic framework as default This patch adds a new system preference (DefaultBibliographicFramework). Using this a librarian can select the bibliographic framework code to set the the bibliographic framework that will be displayed as default when: * Importing batch of biblio records * Editing a biblio record with no mapped biblio framework Test plan: 1. Apply patch 2. Run ./updatedatabase.pl (in installer/data/mysql) from the Koha shell to implement db changes 3. Search for the syspref DefaultBibliographicFramework in Administration module 4. Notice the syspref has the value 'Default' 5. Locate and edit the record of a bibliographic record not mapped to a framework and notice 'Default' is ticked when you click on 'Settings' 6. Click 'Save' and confirm the frameworkcode of the bibliorecord is Default (stored in the database as empty). You can do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber>; 7. Import a batch of biblio records and notice that 'Default' is displayed as the framework to be used 8. Confirm the frameworkcode of one of the imported biblio records is default. Do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber of biblio imported in step 7>; 9. Select a different framework (such as Acquisitions) in the DefaultBibliographicFramework syspref 10. Repeat step 5 but notice the DefaultBibliographicFramework framework as shown as the framework 11. Confirm the biblio has the new frameworkcode. You can do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber>; 12. Repeat step 7 and notice the DefaultBibliographicFramework is shown as the framework to be used 13. Confirm the biblios imported in step 12 have the correct frameworkcode by running the following SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber of imported biblio in step 12>; Authored-by: Alex Buckley Sponsored-by: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90550|0 |1 is obsolete| | Attachment #90588|0 |1 is obsolete| | Attachment #91039|0 |1 is obsolete| | --- Comment #6 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 91040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91040&action=edit Bug 23111: Set custom bibliographic framework as default This patch adds a new system preference (DefaultBibliographicFramework). Using this a librarian can select the bibliographic framework code to set the the bibliographic framework that will be displayed as default when: * Importing batch of biblio records * Editing a biblio record with no mapped biblio framework Test plan: 1. Apply patch 2. Run ./updatedatabase.pl (in installer/data/mysql) from the Koha shell to implement db changes 3. Search for the syspref DefaultBibliographicFramework in Administration module 4. Notice the syspref has the value 'Default' 5. Locate and edit the record of a bibliographic record not mapped to a framework and notice 'Default' is ticked when you click on 'Settings' 6. Click 'Save' and confirm the frameworkcode of the bibliorecord is Default (stored in the database as empty). You can do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber>; 7. Import a batch of biblio records and notice that 'Default' is displayed as the framework to be used 8. Confirm the frameworkcode of one of the imported biblio records is default. Do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber of biblio imported in step 7>; 9. Select a different framework (such as Acquisitions) in the DefaultBibliographicFramework syspref 10. Repeat step 5 but notice the DefaultBibliographicFramework framework as shown as the framework 11. Confirm the biblio has the new frameworkcode. You can do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber>; 12. Repeat step 7 and notice the DefaultBibliographicFramework is shown as the framework to be used 13. Confirm the biblios imported in step 12 have the correct frameworkcode by running the following SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber of imported biblio in step 12>; Authored-by: Alex Buckley Sponsored-by: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #7 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Owen Leonard from comment #2)
Also: Could we get the framework name to show in the system preference instead of just the code? I don't think it's a dealbreaker but it would be more user-friendly.
The latest version of the patch fixes the QA tool warning and replaces the choice in the syspref with frameworktext instead of frameworkcode. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91040|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 91791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91791&action=edit Bug 23111: Set custom bibliographic framework as default This patch adds a new system preference (DefaultBibliographicFramework). Using this a librarian can select the bibliographic framework code to set the the bibliographic framework that will be displayed as default when: * Importing batch of biblio records * Editing a biblio record with no mapped biblio framework Test plan: 1. Apply patch 2. Run ./updatedatabase.pl (in installer/data/mysql) from the Koha shell to implement db changes 3. Search for the syspref DefaultBibliographicFramework in Administration module 4. Notice the syspref has the value 'Default' 5. Locate and edit the record of a bibliographic record not mapped to a framework and notice 'Default' is ticked when you click on 'Settings' 6. Click 'Save' and confirm the frameworkcode of the bibliorecord is Default (stored in the database as empty). You can do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber>; 7. Import a batch of biblio records and notice that 'Default' is displayed as the framework to be used 8. Confirm the frameworkcode of one of the imported biblio records is default. Do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber of biblio imported in step 7>; 9. Select a different framework (such as Acquisitions) in the DefaultBibliographicFramework syspref 10. Repeat step 5 but notice the DefaultBibliographicFramework framework as shown as the framework 11. Confirm the biblio has the new frameworkcode. You can do this by running the SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber>; 12. Repeat step 7 and notice the DefaultBibliographicFramework is shown as the framework to be used 13. Confirm the biblios imported in step 12 have the correct frameworkcode by running the following SQL: SELECT frameworkcode FROM biblio WHERE biblionumber=<biblionumber of imported biblio in step 12>; Authored-by: Alex Buckley Sponsored-by: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I've rebased this commit against master and have re-attached it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Failed QA --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm sorry but this seems to me like a over-complicated approach: why don't we add a 'default' column with a boolean value to the biblio_framework table? Paired with a Koha::BiblioFramework->set_default method that unsets the previous default when called. And that's it? You will need Koha::BiblioFrameworks::get_default as well if you want to avoid crafting the query. in addbiblio.pl you use Koha::BiblioFramework (singular class) and you shouldn't. WE only include the plurals, which in turn include the singular. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #11 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 92184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92184&action=edit Bug 23111: (follow-up) Made Biblio::Framework use statements plural Follow-up based on comment #10 to use Koha::BiblioFrameworks in addbiblio.pl and cataloguing.pref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Tomás Cohen Arazi from comment #10)
I'm sorry but this seems to me like a over-complicated approach: why don't we add a 'default' column with a boolean value to the biblio_framework table? Paired with a Koha::BiblioFramework->set_default method that unsets the previous default when called. And that's it? You will need Koha::BiblioFrameworks::get_default as well if you want to avoid crafting the query.
in addbiblio.pl you use Koha::BiblioFramework (singular class) and you shouldn't. WE only include the plurals, which in turn include the singular.
Hi Tomás, Have included a follow-up patch to change the use statements to plural classes. We're looking into your suggestions now. How do you see the interface for this implemented? i.e. How should the librarians in your opinion set a framework to be the default? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #10)
I'm sorry but this seems to me like a over-complicated approach: why don't we add a 'default' column with a boolean value to the biblio_framework table?
Where would you put the configuration option then? On http://localhost:8081/cgi-bin/koha/admin/biblio_framework.pl?op=add_form&frameworkcode=ACQ? NOTE: It looks like there is no way to Edit the default framework entry, so resetting from another framework to Default could be a problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |aleisha@catalyst.net.nz --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- These patches still apply cleanly. Setting to In Discussion as I think that's more appropriate. Tomás can you please answer Comment #13 when you get a chance? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emjhet@pa.net --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 20842 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Hayley Mapley from comment #12)
(In reply to Tomás Cohen Arazi from comment #10)
I'm sorry but this seems to me like a over-complicated approach: why don't we add a 'default' column with a boolean value to the biblio_framework table? Paired with a Koha::BiblioFramework->set_default method that unsets the previous default when called. And that's it? You will need Koha::BiblioFrameworks::get_default as well if you want to avoid crafting the query.
in addbiblio.pl you use Koha::BiblioFramework (singular class) and you shouldn't. WE only include the plurals, which in turn include the singular.
Hi Tomás,
Have included a follow-up patch to change the use statements to plural classes.
We're looking into your suggestions now.
How do you see the interface for this implemented? i.e. How should the librarians in your opinion set a framework to be the default?
A checkbox on the framework edit page. And a confirmation modal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley@catalyst.net.nz |aleisha@catalyst.net.nz Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91791|0 |1 is obsolete| | Attachment #92184|0 |1 is obsolete| | --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 102602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102602&action=edit Bug 23111: Set a custom framework as the default when importing records or editing records with no framework mapped. To test: 1) Go to edit a biblio with no framework mapped 2) Click the Settings dropdown, notice that the 'Default' framework is selected 3) Go to the Cataloguing home page. Click the main 'New from Z39.50/SRU' button and notice the selected framework in the URL is 'Default' 4) Go to Tools -> Stage MARC records for import. Stage a bibliographic record. Go to Staged MARC management for your newly imported batch. Notice that the frameworks dropdown (above the 'Import this batch into the catalog' button) has the 'Default' framework selected 5) Apply this patch and update the database. Apply the schema changes patch or update your schema files. Restart memcached and plack. 6) Go to Administration -> MARC bibliographic frameworks. Edit one of your custom frameworks. Set it as default by checking the checkbox and saving. 7) Edit a different custom framework and set this one as the default now. Confirm that the previous framework has been unset (the checkbox is no longer checked) as the default. 8) Repeat steps 1-4 and confirm that the selected framework is your newly set default framework, instead of the provided 'Default' framework. 9) Go back to Administration -> MARC bibliographic frameworks. Edit your default framework and unset it as default (uncheck the checkbox). Save. 10) Repeat steps 1-4 and confirm that the selected framework is the provided 'Default' framework again, so we can have no default custom framework if chosen. 11) Confirm the tests pass: t/db_dependent/Koha/BiblioFrameworks.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 102603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102603&action=edit Bug 23111: (follow-up) Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds the ability release notes| |to set a custom framework | |as the default to be | |applied when importing | |records or editing records | |with no framework mapped. Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- I'm getting his error when doing a search in cataloging (/cgi-bin/koha/cataloguing/addbooks.pl?q=blue): DBIx::Class::ResultSource::_resolve_join(): No such relationship marc_subfield_structures on AuthorisedValueCategory at /kohadevbox/koha/Koha/Objects.pm line 130 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #19)
I'm getting his error when doing a search in cataloging (/cgi-bin/koha/cataloguing/addbooks.pl?q=blue):
DBIx::Class::ResultSource::_resolve_join(): No such relationship marc_subfield_structures on AuthorisedValueCategory at /kohadevbox/koha/Koha/Objects.pm line 130 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
Sorry Owen I don't get this error. Perhaps some data problem? Setting back to Needs Signoff to see if someone else can confirm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, no problem searching, test pass, works. qa-tools complains FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column biblio_framework.is_default is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/BiblioFramework.pm), see the SQL12 coding guideline Why not use an smallint/int type? Seems like a false positive to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Bernardo Gonzalez Kriegel from comment #21)
Hi, no problem searching, test pass, works.
qa-tools complains FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column biblio_framework.is_default is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/BiblioFramework.pm), see the SQL12 coding guideline
Why not use an smallint/int type? Seems like a false positive to me.
See the coding guidelines on the Koha Community wiki about booleans: https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans I realise I have done this wrong so will fix it up anyway, but guidelines say to use tinyint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 12194 might be helpful here - I think it's a 'right' positive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102603|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104058&action=edit Bug 23111: Schema changes If not testing on a sandbox, do not apply this patch. Instead, apply first patch, update dbix files, then apply final patch and test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #25 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104059&action=edit Bug 23111: Making is_default a boolean flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102602|0 |1 is obsolete| | --- Comment #26 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 104060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104060&action=edit Bug 23111: Set a custom framework as the default when importing records or editing records with no framework mapped. To test: 1) Go to edit a biblio with no framework mapped 2) Click the Settings dropdown, notice that the 'Default' framework is selected 3) Go to the Cataloguing home page. Click the main 'New from Z39.50/SRU' button and notice the selected framework in the URL is 'Default' 4) Go to Tools -> Stage MARC records for import. Stage a bibliographic record. Go to Staged MARC management for your newly imported batch. Notice that the frameworks dropdown (above the 'Import this batch into the catalog' button) has the 'Default' framework selected 5) Apply this patch and update the database. Apply the schema changes patch or update your schema files. Restart memcached and plack. 6) Go to Administration -> MARC bibliographic frameworks. Edit one of your custom frameworks. Set it as default by checking the checkbox and saving. 7) Edit a different custom framework and set this one as the default now. Confirm that the previous framework has been unset (the checkbox is no longer checked) as the default. 8) Repeat steps 1-4 and confirm that the selected framework is your newly set default framework, instead of the provided 'Default' framework. 9) Go back to Administration -> MARC bibliographic frameworks. Edit your default framework and unset it as default (uncheck the checkbox). Save. 10) Repeat steps 1-4 and confirm that the selected framework is the provided 'Default' framework again, so we can have no default custom framework if chosen. 11) Confirm the tests pass: t/db_dependent/Koha/BiblioFrameworks.t Sponsored-by: Catalyst IT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104058|0 |1 is obsolete| | --- Comment #27 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 104061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104061&action=edit Bug 23111: Schema changes If not testing on a sandbox, do not apply this patch. Instead, apply first patch, update dbix files, then apply final patch and test. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104059|0 |1 is obsolete| | --- Comment #28 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 104062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104062&action=edit Bug 23111: Making is_default a boolean flag Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Aleisha Amohia from comment #22)
See the coding guidelines on the Koha Community wiki about booleans: https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans
I realise I have done this wrong so will fix it up anyway, but guidelines say to use tinyint.
(In reply to Katrin Fischer from comment #23)
Bug 12194 might be helpful here - I think it's a 'right' positive.
I read the coding guidelines, but didn't know if it was intended to be Boolean, so a type change would fix the problem. If that was the intention, it needed to be declared, and was a 'right' positive :) Tested and signed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aleisha, 1) At the moment you can't tell from the administration page, which is the current default framework. Could you add a column or note there to show the current default? (/cgi-bin/koha/admin/biblio_framework.pl). I think this would be really helpful. I wonder if a hint would be helpful "unset to make default default" (better phrased) as this might not be intuitive (no edit option for the default framework). 2) It looks like the advanced editor still defaults to default - should this be changed as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106560&action=edit Bug 23111: (QA follow-up) Add AFTER to update database statement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #32 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112354&action=edit Bug 23111: (follow-up) Add a column to show default framework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #33 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #30)
2) It looks like the advanced editor still defaults to default - should this be changed as well?
I have implemented everything except this point, I'm not sure the best way to go about it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #34 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112468&action=edit Bug 23111: (follow-up) set default framework on advanced editor This patch ensures the advanced editor considers the default biblio framework. Also fixing bug in atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #35 from David Cook <dcook@prosentient.com.au> --- (In reply to Aleisha Amohia from comment #33)
(In reply to Katrin Fischer from comment #30)
2) It looks like the advanced editor still defaults to default - should this be changed as well?
I have implemented everything except this point, I'm not sure the best way to go about it!
I feel like the advanced editor is its own beast >_>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #36 from Holly <hc@interleaf.ie> --- Is the test from comment 26 still valid? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104060|0 |1 is obsolete| | Attachment #106560|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 138766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138766&action=edit Bug 23111: Set a custom framework as the default when importing records or editing records with no framework mapped. To test: 1) Go to edit a biblio with no framework mapped 2) Click the Settings dropdown, notice that the 'Default' framework is selected 3) Go to the Cataloguing home page. Click the main 'New from Z39.50/SRU' button and notice the selected framework in the URL is 'Default' 4) Go to Tools -> Stage MARC records for import. Stage a bibliographic record. Go to Staged MARC management for your newly imported batch. Notice that the frameworks dropdown (above the 'Import this batch into the catalog' button) has the 'Default' framework selected 5) Apply this patch and update the database. Apply the schema changes patch or update your schema files. Restart memcached and plack. 6) Go to Administration -> MARC bibliographic frameworks. Edit one of your custom frameworks. Set it as default by checking the checkbox and saving. 7) Edit a different custom framework and set this one as the default now. Confirm that the previous framework has been unset (the checkbox is no longer checked) as the default. 8) Repeat steps 1-4 and confirm that the selected framework is your newly set default framework, instead of the provided 'Default' framework. 9) Go back to Administration -> MARC bibliographic frameworks. Edit your default framework and unset it as default (uncheck the checkbox). Save. 10) Repeat steps 1-4 and confirm that the selected framework is the provided 'Default' framework again, so we can have no default custom framework if chosen. 11) Confirm the tests pass: t/db_dependent/Koha/BiblioFrameworks.t Sponsored-by: Catalyst IT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104061|0 |1 is obsolete| | --- Comment #38 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 138767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138767&action=edit Bug 23111: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104062|0 |1 is obsolete| | --- Comment #39 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 138768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138768&action=edit Bug 23111: Making is_default a boolean flag Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112354|0 |1 is obsolete| | --- Comment #40 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 138769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138769&action=edit Bug 23111: (follow-up) Add a column to show default framework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112468|0 |1 is obsolete| | --- Comment #41 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 138770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138770&action=edit Bug 23111: (follow-up) set default framework on advanced editor This patch ensures the advanced editor considers the default biblio framework. Also fixing bug in atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15786 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138766|0 |1 is obsolete| | --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 141565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141565&action=edit Bug 23111: Set a custom framework as the default when importing records or editing records with no framework mapped. To test: 1) Go to edit a biblio with no framework mapped 2) Click the Settings dropdown, notice that the 'Default' framework is selected 3) Go to the Cataloguing home page. Click the main 'New from Z39.50/SRU' button and notice the selected framework in the URL is 'Default' 4) Go to Tools -> Stage MARC records for import. Stage a bibliographic record. Go to Staged MARC management for your newly imported batch. Notice that the frameworks dropdown (above the 'Import this batch into the catalog' button) has the 'Default' framework selected 5) Apply this patch and update the database. Apply the schema changes patch or update your schema files. Restart memcached and plack. 6) Go to Administration -> MARC bibliographic frameworks. Edit one of your custom frameworks. Set it as default by checking the checkbox and saving. 7) Edit a different custom framework and set this one as the default now. Confirm that the previous framework has been unset (the checkbox is no longer checked) as the default. 8) Repeat steps 1-4 and confirm that the selected framework is your newly set default framework, instead of the provided 'Default' framework. 9) Go back to Administration -> MARC bibliographic frameworks. Edit your default framework and unset it as default (uncheck the checkbox). Save. 10) Repeat steps 1-4 and confirm that the selected framework is the provided 'Default' framework again, so we can have no default custom framework if chosen. 11) Confirm the tests pass: t/db_dependent/Koha/BiblioFrameworks.t Sponsored-by: Catalyst IT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138767|0 |1 is obsolete| | --- Comment #43 from David Nind <david@davidnind.com> --- Created attachment 141566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141566&action=edit Bug 23111: Schema changes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138768|0 |1 is obsolete| | --- Comment #44 from David Nind <david@davidnind.com> --- Created attachment 141567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141567&action=edit Bug 23111: Making is_default a boolean flag Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138769|0 |1 is obsolete| | --- Comment #45 from David Nind <david@davidnind.com> --- Created attachment 141568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141568&action=edit Bug 23111: (follow-up) Add a column to show default framework Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138770|0 |1 is obsolete| | --- Comment #46 from David Nind <david@davidnind.com> --- Created attachment 141569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141569&action=edit Bug 23111: (follow-up) set default framework on advanced editor This patch ensures the advanced editor considers the default biblio framework. Also fixing bug in atomic update Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #47 from David Nind <david@davidnind.com> --- I've signed off as everything works as per the test plan. I enable the advanced editor (EnableAdvancedCatalogingEditor system preference) and this worked as expected with this change. I did note that in the staff interface when on the details page for an existing record, you have the option of New > New record - this defaults to the default framework even if another framework is set as the default. There may be other areas where /cgi-bin/koha/cataloguing/addbiblio.pl is used... possibly these can be addressed in a follow-up bug when these are identified, for example in the acquisitions area. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Giving this another round of testing: I have made the FA framework my default. This worked nicely. 1) Open a record that has been saved with ACQ framework. Try to switch to Default. The "Change framework" list will have the checkmark at "FA", but the display will be the default framework. Switching to other frameworks works, so it might have to do with the "" of default. 2) I feel we should fix that one David found and that I confirmed within this patch set. There are 2 'major' ways to create a new record (from cataloguing module and form detail page) and as this is one of them, I think it makes sense to have it part here: I did note that in the staff interface when on the details page for an existing record, you have the option of New > New record - this defaults to the default framework even if another framework is set as the default. 3) When a new record is created with "order from new" in acq, and UseACQFrameworkForBiblioRecords is set to Don't use, the record will be using "default". This is less blocker than 2, but if it's not an easy fix, we should file a bug for it. We've just recently had a request for this on the German mailing list, would love to see this make it into 22.11 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimalibre@gmail.com --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34703 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141565|0 |1 is obsolete| | --- Comment #50 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157717&action=edit Bug 23111: Set a custom framework as the default when importing records or editing records with no framework mapped. To test: 1) Go to edit a biblio with no framework mapped 2) Click the Settings dropdown, notice that the 'Default' framework is selected 3) Go to the Cataloguing home page. Click the main 'New from Z39.50/SRU' button and notice the selected framework in the URL is 'Default' 4) Go to Tools -> Stage MARC records for import. Stage a bibliographic record. Go to Staged MARC management for your newly imported batch. Notice that the frameworks dropdown (above the 'Import this batch into the catalog' button) has the 'Default' framework selected 5) Apply this patch and update the database. Apply the schema changes patch or update your schema files. Restart memcached and plack. 6) Go to Administration -> MARC bibliographic frameworks. Edit one of your custom frameworks. Set it as default by checking the checkbox and saving. 7) Edit a different custom framework and set this one as the default now. Confirm that the previous framework has been unset (the checkbox is no longer checked) as the default. 8) Repeat steps 1-4 and confirm that the selected framework is your newly set default framework, instead of the provided 'Default' framework. 9) Go back to Administration -> MARC bibliographic frameworks. Edit your default framework and unset it as default (uncheck the checkbox). Save. 10) Repeat steps 1-4 and confirm that the selected framework is the provided 'Default' framework again, so we can have no default custom framework if chosen. 11) Confirm the tests pass: t/db_dependent/Koha/BiblioFrameworks.t Sponsored-by: Catalyst IT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141566|0 |1 is obsolete| | --- Comment #51 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157718&action=edit Bug 23111: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141567|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157719&action=edit Bug 23111: Making is_default a boolean flag Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141568|0 |1 is obsolete| | --- Comment #53 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157720&action=edit Bug 23111: (follow-up) Add a column to show default framework Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141569|0 |1 is obsolete| | --- Comment #54 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157721&action=edit Bug 23111: (follow-up) set default framework on advanced editor This patch ensures the advanced editor considers the default biblio framework. Also fixing bug in atomic update Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #55 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157722&action=edit Bug 23111: Allow switch to Default framework and use selected default when adding New record This ensures that the correct framework is checked when using the 'Change framework' dropdown in the editor. This also ensures that the selected default framework is used when using the New record button in the Cataloguing home page or from a record detail page. You would also still be able to use the Default framework if chosen. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #56 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157723&action=edit Bug 23111: Use selected default framework if UseACQFrameworkForBiblioRecords set to Don't Use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #57 from David Nind <david@davidnind.com> --- Two issues I came across when testing (using KTD): 1. Cataloguing > New from Z39.50/SRU: framework in URL is Default, even if another framework (such as BKS) is set as the default: . 127.0.0.1:8081/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=&frameworkcode=Default 2. Page not found error for Cataloguing > New record, after unsetting the default framework (so that the Default framework is now the default): - URL is: http://127.0.0.1:8081/cgi-bin/koha/cataloguing/undefined - Error 404 page (An error has occurred) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik@adminkuhn.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org