[Bug 38457] New: custom field in debit type to allow for external finance system codes to be added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Bug ID: 38457 Summary: custom field in debit type to allow for external finance system codes to be added Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Point of Sale Assignee: koha-bugs@lists.koha-community.org Reporter: hdunne-howrie@westminster.gov.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com Problem - Any external finance systems have separate codes that may not align 1:1 with debit type lines. For example, a library might have a retail offer with 50 item lines but these products may align to 10 finance codes. This means it is time consuming/impossible for staff during finance reporting to match up finance codes with item lines from Koha reports. Proposed solution - An additional field within debit types would allow us to add in these finance codes and create reports based on takings by these codes (as opposed to each individual debit type line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- We're going to take this on within PTFS Europe, it's on my list to assign it out to the team today and schedule it very early in the next community cycle (i.e. coding to take place before xmas) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|custom field in debit type |Add custom field in debit |to allow for external |type to allow for external |finance system codes to be |finance system codes to be |added |added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38663 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 [Bug 38663] Add additional fields to libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175630&action=edit Bug 38457: DBIC Add AdditionalFields to AccountDebitType -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175631&action=edit Bug 38457: Add additional fields to debit types Test plan, k-t-d: 1) Before defining any additional fields for account_debit_types, confirm that the 'Additional fields' section does not appear when attempting to add a new or edit an existing debit type. 2) Add a new additional field to 'account_debit_types': <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_debit_types 3) Click 'New field'. Add a name. Click Save. 4) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 5) Edit an account debit type: <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL 6) Input various values in the different additional fields. Click 'Submit' 7) Edit the same debit type again and note the additional fields added in the previous step are visible <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175633&action=edit Bug 38457: Add additional fields to debit display This patch adds the previously added additional fields to the display in the debit types management page table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.jones@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add custom field in debit |Add additional fields |type to allow for external |support to debit types |finance system codes to be | |added | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Add additional fields to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175630|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176789&action=edit Bug 38457: DBIC Add AdditionalFields to AccountDebitType Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175631|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176790&action=edit Bug 38457: Add additional fields to debit types Test plan, k-t-d: 1) Before defining any additional fields for account_debit_types, confirm that the 'Additional fields' section does not appear when attempting to add a new or edit an existing debit type. 2) Add a new additional field to 'account_debit_types': <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_debit_types 3) Click 'New field'. Add a name. Click Save. 4) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 5) Edit an account debit type: <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL 6) Input various values in the different additional fields. Click 'Submit' 7) Edit the same debit type again and note the additional fields added in the previous step are visible <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175633|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176791&action=edit Bug 38457: Add additional fields to debit display This patch adds the previously added additional fields to the display in the debit types management page table Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Added sponsorship lines and this is about to get pushed to a site we're implementing right now so should be signed off soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176789|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178394&action=edit Bug 38457: DBIC Add AdditionalFields to AccountDebitType Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176790|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178395&action=edit Bug 38457: Add additional fields to debit types Test plan, k-t-d: 1) Before defining any additional fields for account_debit_types, confirm that the 'Additional fields' section does not appear when attempting to add a new or edit an existing debit type. 2) Add a new additional field to 'account_debit_types': <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_debit_types 3) Click 'New field'. Add a name. Click Save. 4) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 5) Edit an account debit type: <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL 6) Input various values in the different additional fields. Click 'Submit' 7) Edit the same debit type again and note the additional fields added in the previous step are visible <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176791|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178396&action=edit Bug 38457: Add additional fields to debit display This patch adds the previously added additional fields to the display in the debit types management page table Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178397&action=edit Bug 38457: Update record_id to VARCHAR(80) This is required to allow for long primary keys from the account_debit_types table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178398&action=edit Bug 38457: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39177 [Bug 39177] Add additional fields support to credit types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #15 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tried to test this on PTFS Europe's sandbox but account_debit_types table does not come visible in Additional fields page and if I use the direct address <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_debit_types you can add a field but it does not show in Debit types page. Is it possible to test this on sandbox? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Hmm.. I would think this is testable via sandboxes.. I'm just confirming that now myself. We have deployed this, backported to 24.11.x, to a customer site who are going live in the next month and it's working well there currently. I'll report back -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- OK.. for me at least it looks like sha1 application issues.. i.e the patches never actually applied to the sandbox. That's good in so much as it doesn't point to an issue with the patchset here but it does show one of the challenges with the sandboxes output.. they don't report failures to apply patches properly unless you know what to look for in the logs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #18 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- patch isn't applying cleanly in k-t-d either Applying: Bug 38457: Add additional fields to debit types error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt). error: could not build fake ancestor Patch failed at 0001 Bug 38457: Add additional fields to debit types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178394|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180494&action=edit Bug 38457: DBIC Add AdditionalFields to AccountDebitType Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178395|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180495&action=edit Bug 38457: Add additional fields to debit types Test plan, k-t-d: 1) Before defining any additional fields for account_debit_types, confirm that the 'Additional fields' section does not appear when attempting to add a new or edit an existing debit type. 2) Add a new additional field to 'account_debit_types': <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_debit_types 3) Click 'New field'. Add a name. Click Save. 4) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 5) Edit an account debit type: <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL 6) Input various values in the different additional fields. Click 'Submit' 7) Edit the same debit type again and note the additional fields added in the previous step are visible <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178396|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180496&action=edit Bug 38457: Add additional fields to debit display This patch adds the previously added additional fields to the display in the debit types management page table Sponsored-by: PTFS Europe <https://ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178397|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180497&action=edit Bug 38457: Update record_id to VARCHAR(80) This is required to allow for long primary keys from the account_debit_types table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178398|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180498&action=edit Bug 38457: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180494|0 |1 is obsolete| | --- Comment #24 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 180519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180519&action=edit Bug 38457: DBIC Add AdditionalFields to AccountDebitType Sponsored-by: PTFS Europe <https://ptfs-europe.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180495|0 |1 is obsolete| | --- Comment #25 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 180520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180520&action=edit Bug 38457: Add additional fields to debit types Test plan, k-t-d: 1) Before defining any additional fields for account_debit_types, confirm that the 'Additional fields' section does not appear when attempting to add a new or edit an existing debit type. 2) Add a new additional field to 'account_debit_types': <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_debit_types 3) Click 'New field'. Add a name. Click Save. 4) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 5) Edit an account debit type: <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL 6) Input various values in the different additional fields. Click 'Submit' 7) Edit the same debit type again and note the additional fields added in the previous step are visible <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL Sponsored-by: PTFS Europe <https://ptfs-europe.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180496|0 |1 is obsolete| | --- Comment #26 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 180521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180521&action=edit Bug 38457: Add additional fields to debit display This patch adds the previously added additional fields to the display in the debit types management page table Sponsored-by: PTFS Europe <https://ptfs-europe.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180497|0 |1 is obsolete| | --- Comment #27 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 180522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180522&action=edit Bug 38457: Update record_id to VARCHAR(80) This is required to allow for long primary keys from the account_debit_types table. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180498|0 |1 is obsolete| | --- Comment #28 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 180523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180523&action=edit Bug 38457: DBIC Schema Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #29 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I'm not sure if this was testable in sandbox but I tested this in a Bywater's sandbox. Some notes: * A new additional field can be added on that page. * If I try to edit a existing debit type I get an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.record_id' in 'on clause' at /kohadevbox/koha/Koha/Objects.pm line 319 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 * If I add a new debit type, the newly added additional field is visible and can be added/selected but when I save the debit type I get an error message"An error occurred when saving this debit type. Check the logs for details.." The debit type is still added. * If I try to edit the new debit type, I get the same error as with editing existing debit type: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.record_id' in 'on clause' at /kohadevbox/koha/Koha/Objects.pm line 319 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Patch doesn't apply --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Looks like there are a couple small rebases needed here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180519|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182384&action=edit Bug 38457: DBIC Add AdditionalFields to AccountDebitType Sponsored-by: PTFS Europe <https://ptfs-europe.com> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180520|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182385&action=edit Bug 38457: Add additional fields to debit types Test plan, k-t-d: 1) Before defining any additional fields for account_debit_types, confirm that the 'Additional fields' section does not appear when attempting to add a new or edit an existing debit type. 2) Add a new additional field to 'account_debit_types': <staff_url>/cgi-bin/koha/admin/additional-fields.pl?tablename=account_debit_types 3) Click 'New field'. Add a name. Click Save. 4) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 5) Edit an account debit type: <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL 6) Input various values in the different additional fields. Click 'Submit' 7) Edit the same debit type again and note the additional fields added in the previous step are visible <staff_url>/cgi-bin/koha/admin/debit_types.pl?op=add_form&code=MANUAL Sponsored-by: PTFS Europe <https://ptfs-europe.com> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180521|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182386&action=edit Bug 38457: Add additional fields to debit display This patch adds the previously added additional fields to the display in the debit types management page table Sponsored-by: PTFS Europe <https://ptfs-europe.com> Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180522|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182387&action=edit Bug 38457: Update record_id to VARCHAR(80) This is required to allow for long primary keys from the account_debit_types table. Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180523|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182388&action=edit Bug 38457: DBIC Schema Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- That was an interesting rebase.. the auto tidy stuff had royally screwed up the intermediary patches Anywho.. rebased now and restoring status of the bug to PQA as it's had Hannah signoff and Laura QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please use "say_success" :) + say $out "Converted record_id to VARCHAR(80)"; This appears pretty contained to the configuration page for now. I'd be interested in some use cases/best practice for documentation and when demoing this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, something is not quite right here, but I am not spotting it right now, can you please take a look? https://jenkins.koha-community.org/job/Koha_Main_MariaDB_update/155/console -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182575&action=edit Bug 38457: (follow-up) Update record_id to VARCHAR(80) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Component|Point of Sale |Fines and fees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds additional fields release notes| |to the debit type | |configuration page. One | |possible use case could be | |to store additional | |financial codes needed for | |reporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds additional fields |**Summary:** release notes|to the debit type |Debit types |configuration page. One |were previously limited in |possible use case could be |customization, restricting |to store additional |the ability to store extra |financial codes needed for |metadata. |reporting. | | |**Enhancement:** | | | |Additional fields can now | |be configured for debit | |types, allowing storage of | |custom financial codes or | |reporting data. | | | |**Impact:** | |Improves | |flexibility for libraries | |with advanced accounting or | |reporting requirements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #41 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Bug 38457 depends on bug 38663, which changed state. Bug 38663 Summary: Add additional fields to libraries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1097 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40926 [Bug 40926] Make additional fields for debits and credits visible in table and searchable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40926 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40926 [Bug 40926] Make additional fields for debits and credits visible in table and searchable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40926 [Bug 40926] Make additional fields for debits and credits visible in table and searchable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40926 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40926 [Bug 40926] Make additional fields for debits and credits visible in table and searchable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org