[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #170 from Magnus Enger <magnus@libriotech.no> --- Trying to summarize the status of this bug now. *** QA script ** POD coverage Some FAILS are "POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666". It sounds like these can be ignored. ** Atomicupdate FAIL installer/data/mysql/atomicupdate/ill_tables.sql FAIL git manipulation The file has been added and deleted in the same patchset Alex provided ill_tables.sql. Tomas rewrote it as bug_7317_ill.perl. Not sure there is anything to fix here? ** tt_valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt OK forbidden patterns OK git manipulation OK spelling FAIL tt_valid lines 665 FAIL valid_template : not found TT is used to set some HTML attributes. Not sure if this can be fixed. Tomas? *** (In reply to Jonathan Druart from comment #164)
1/ +TODO: + +- Anything invoking the ->status method; annotated with: + + # Old use of ->status !
What do it mean?
OK, according to Tomas.
2/ I will not make you rewrite everything, but it would have been better to stay consistent and not mix snake_case and camelCase for method names.
OK
First steps with the GUI: 3/ This is what I see when I enable the module: https://screenshots.firefox.com/z9dNoRL91NQ5F3cD/pro.kohadev.org Looks wrong.
Not sure if this can be fixed?
4/ Hit /cgi-bin/koha/ill/ill-requests.pl and got: Loading failed for the <script> with source “http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery. tablesorter.min.js”. ill-requests.pl:151 Loading failed for the <script> with source “http://pro.kohadev.org/intranet-tmpl/prog/en/lib/jquery/plugins/jquery. checkboxes.min.js”. ill-requests.pl:152
OK. Fixed by Tomas
5/ Clicked "New ILL request" button and got: Can't locate Koha/Illbackends//Base.pm
OK. Fixed by Tomas. But it sounds like Tomas will be working a bit more on related things. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org