https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Owen Leonard from comment #17)

I'm still getting warnings from the QA tool:

FAIL installer/data/mysql/en/mandatory/sample_notices.yml FAIL yaml_valid ARRAY(0x55d88d804738)

The change to sample_notices.yml also lacks a value for "module," which is required.

After applying the patch and running "reset_all" in koha-testing-docker I see this error in the output:

C4::Installer::load_sql returned the following errors while attempting to load /kohadevbox/koha/installer/data/mysql/en/mandatory/sample_notices.yml: DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`letter`, CONSTRAINT `message_transport_type_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDA) at /kohadevbox/koha/C4/Installer.pm line 574.

I was unable to produce these errors, but fixed invalid yaml syntax and missing "module" value to the first patch. Also fixed atomicupdate files name (there was cap between 12285 and -allow) and added IGNORE to INSERT statement (my wild guess is that this caused that last error). -- You are receiving this mail because: You are watching all bug changes.