[Bug 30509] New: Accordion on letter.tt is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Bug ID: 30509 Summary: Accordion on letter.tt is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org At '/cgi-bin/koha/tools/letter.pl' the accordion for changing between Email, Print, SMS notice templates is broken. All of the templates are showing at the same time. It looks to be related to a JS error coming from letter.js: Uncaught TypeError: t.find(...).even is not a function -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |30011 Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133196&action=edit Bug 30509: Fix configuration of Notices accordion widget The jQueryUI upgrade broke the Accordion on the notices edit page. I'm not sure why, but defining a "header" option in the accordion configuration fixes it. To test, apply the patch and test the notices edit page both with and without TranslateNotices and multiple languages installed. In both cases the different sections (Email, Print, SMS) should open and close correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133196|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 133197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133197&action=edit Bug 30509: Fix configuration of Notices accordion widget The jQueryUI upgrade broke the Accordion on the notices edit page. I'm not sure why, but defining a "header" option in the accordion configuration fixes it. To test, apply the patch and test the notices edit page both with and without TranslateNotices and multiple languages installed. In both cases the different sections (Email, Print, SMS) should open and close correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Bug 30509 depends on bug 30011, which changed state. Bug 30011 Summary: Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133197|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133392&action=edit Bug 30509: Fix configuration of Notices accordion widget The jQueryUI upgrade broke the Accordion on the notices edit page. I'm not sure why, but defining a "header" option in the accordion configuration fixes it. To test, apply the patch and test the notices edit page both with and without TranslateNotices and multiple languages installed. In both cases the different sections (Email, Print, SMS) should open and close correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, fix works as described and I'm not seeing any other regressions.. No idea why it works though, I can't find anything in the jQueryUI docs to suggest this is required.. But.. it works.. so Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.06 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30509 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org