[Bug 26538] New: Display cities list before input text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Bug ID: 26538 Summary: Display cities list before input text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110765&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110766&action=edit Bug 26538: Display cities list before input text In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. Test plan : 1) Create some cities 2) Open patron creation form 3) Check you see for each city field : cities list, text "or enter", text input 4) Delete all cities 5) Open patron creation form 6) Check you see for each city field : only text input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I like this change -- staff at my library seem to often forget they can select a predefined city. Unfortunately parts of it aren't working for me: Selecting "main address" cit or "alternate address" city does not trigger the automatic population of values to the city, state, and zip fields. It does work for the "alternate contact" fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #3)
I like this change -- staff at my library seem to often forget they can select a predefined city.
Unfortunately parts of it aren't working for me: Selecting "main address" cit or "alternate address" city does not trigger the automatic population of values to the city, state, and zip fields.
It does work for the "alternate contact" fields.
Ah, for me this does no work on master without my patch ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Oh I found why, I'm on a patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26556 [Bug 26556] Cities autocomplete broken in patron edition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26556 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26556 [Bug 26556] Cities autocomplete broken in patron edition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26556 [Bug 26556] Cities autocomplete broken in patron edition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #5)
Oh I found why, I'm on a patch
Bug 26556 is now in master (whaoo fast). You can test again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |moremembers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|moremembers |moremembers2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|moremembers2 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110766|0 |1 is obsolete| | --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 111518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111518&action=edit Bug 26538: Display cities list before input text In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. Test plan : 1) Create some cities 2) Open patron creation form 3) Check you see for each city field : cities list, text "or enter", text input 4) Delete all cities 5) Open patron creation form 6) Check you see for each city field : only text input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Rebased, thanks a lot for testing David :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111518|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111540&action=edit Bug 26538: Display cities list before input text In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. Test plan : 1) Create some cities 2) Open patron creation form 3) Check you see for each city field : cities list, text "or enter", text input 4) Delete all cities 5) Open patron creation form 6) Check you see for each city field : only text input Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111540|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111565&action=edit Bug 26538: Display cities list before input text In patron creation or edition actually the city field is displayed with input text then cities list. I propose to display cities list first since it is more likely used. Test plan : 1) Create some cities 2) Open patron creation form 3) Check you see for each city field : cities list, text "or enter", text input 4) Delete all cities 5) Open patron creation form 6) Check you see for each city field : only text input Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha@catalyst.net.nz --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26538 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org