[Bug 27141] New: QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 Bug ID: 27141 Summary: QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Since QueryAutoTruncate automatically disables QueryWeightFields, it does not make sense that both are set to 1 in "./installer/data/mysql/sysprefs.sql" I think that we should have QueryWeightFields set to 0 for new installations. It would even be tempting to set QueryWeightFields to 0 where QueryAutoTruncate is set to 1 on existing installs, except that someone might be (unwisely) trialling different Query* settings before/during a Koha upgrade. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9715 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should do the opposite - turn QueryWeightFields on and turn QueryAutoTruncate off. In my testing for a recent presentation I felt tihs to give much better and expected results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #1)
I think we should do the opposite - turn QueryWeightFields on and turn QueryAutoTruncate off.
In my testing for a recent presentation I felt tihs to give much better and expected results.
Personally, I hate the query mangling done by QueryWeightFields, but I think that you make a good point. Recently, I turned off QueryAutoTruncate and turned on QueryWeightFields to get a better search experience for a new Koha library. (I have also been thinking about creating a QuerySimplified or QueryCCL option to get rid of all the query mangling and instead do something more simple and straightforward.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm I think the "query mangling" is actually good in this case. I recently looked at the code and it does make sense to me what we are trying to do here - judging from results it also appears to work reasonably well. Do you have a specific issue with it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #3)
Hm I think the "query mangling" is actually good in this case. I recently looked at the code and it does make sense to me what we are trying to do here - judging from results it also appears to work reasonably well.
Do you have a specific issue with it?
I think that it's trying to be too smart for its own good.
From my perspective, the user should be able to build up their own query and get search results that actually reflect their query, rather than a mangled query.
That being said, I am a power user, so maybe novice users would prefer the system to think for them. Maybe my other issues are actually about inconsistency and inefficiency in the query building in general, but... my latest buildQuery unit tests actually provide the start for improving the search code overall... maybe I'm just having a grump ;). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Do I remember wrongly that we fixed one pref killing the other? I wonder how we can proceed here. Happy to write a patch to change the default values if we can agree on something. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #5)
Do I remember wrongly that we fixed one pref killing the other?
I wonder how we can proceed here. Happy to write a patch to change the default values if we can agree on something.
I don't think it's fixed but I haven't verified it recently. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org