[Bug 34225] New: KohaTable broken on batch item deletion and modification results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Bug ID: 34225 Summary: KohaTable broken on batch item deletion and modification results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: nick@bywatersolutions.com Depends on: 32970 Bug 32970 updated batchMod.js to use the columns_settings include and KohaTable to create the DataTable in background job results. However, batchMod.js is also used for the results view of batch item modification and batch item deletion. Without the addition of columns_settings.inc on these pages as well there is a JS error in the console and the tables are static. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970 [Bug 32970] Allow export of batch item modification results in background jobs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153171&action=edit Bug 34225: KohaTable broken on batch item deletion and modification results This patch adds the columns_settings include file to the batch item modification and batch item deletion templates so that the tables can be rendered as DataTables. To test, apply the patch and go to Cataloging -> Batch item modification. - Submit a batch of barcodes or item numbers for modification. - On the next page which shows all the items you submitted, the table should be rendered as a DataTable. - Confirm that sorting, filtering, and export all work correctly. - Confirm that there are not JS errors in the browser console. - Perform the same tests on Cataloging -> Batch item deletion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153171|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 153190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153190&action=edit Bug 34225: KohaTable broken on batch item deletion and modification results This patch adds the columns_settings include file to the batch item modification and batch item deletion templates so that the tables can be rendered as DataTables. To test, apply the patch and go to Cataloging -> Batch item modification. - Submit a batch of barcodes or item numbers for modification. - On the next page which shows all the items you submitted, the table should be rendered as a DataTable. - Confirm that sorting, filtering, and export all work correctly. - Confirm that there are not JS errors in the browser console. - Perform the same tests on Cataloging -> Batch item deletion. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153190|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153222&action=edit Bug 34225: KohaTable broken on batch item deletion and modification results This patch adds the columns_settings include file to the batch item modification and batch item deletion templates so that the tables can be rendered as DataTables. To test, apply the patch and go to Cataloging -> Batch item modification. - Submit a batch of barcodes or item numbers for modification. - On the next page which shows all the items you submitted, the table should be rendered as a DataTable. - Confirm that sorting, filtering, and export all work correctly. - Confirm that there are not JS errors in the browser console. - Perform the same tests on Cataloging -> Batch item deletion. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34225 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Not backporting to 22.11.x - missing dependency 32970 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org