https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 62562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62562&action=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner To reproduce: - Go to Home > Administration > Budgets > Funds > Modify fund ... - Click "Select owner" - In pop up window, search for patrons In the result list, the patron's name etc. is linked to the patron's detail page. If you accidentally click on the link, their detail screen is displayed inside the pop up. No way to get back to the selection screen. (You have to close the pop up and start over adding.) To test: - Apply patch, restart memcached and plack - Repeat steps above, verify that the patron's name is no longer linked - Verify that no other windows are affected where the link is necessary or useful -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I'm proposing an alternate solution which affects not just the patron search for fund owner but other similar pop-up searches too. In my version the patron link triggers a modal windows with more patron details. This eliminates the unwanted redirection while still allowing the user to get more information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75461|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77743&action=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- When I try to apply the patch, it's giving me a conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62562|0 |1 is obsolete| | Attachment #78395|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78925&action=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner To reproduce: - Go to Home > Administration > Budgets > Funds > Modify fund ... - Click "Select owner" - In pop up window, search for patrons In the result list, the patron's name etc. is linked to the patron's detail page. If you accidentally click on the link, their detail screen is displayed inside the pop up. No way to get back to the selection screen. (You have to close the pop up and start over adding.) To test: - Apply patch, restart memcached and plack - Repeat steps above, verify that the patron's name is no longer linked - Verify that no other windows are affected where the link is necessary or useful -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Some comments : 1) If I click to view a patron, close the modal, and click to view another one, the information takes a second to change from the previous patron to the new patron. I don't know if this has to do with plack or memcached, I don't know how to reset those. 2) Would it be possible to add a "Select" or "Add" button in the modal, so that if we view the patron info and decide this is the patron we want, we don't have to close the modal, then look for the patron in the list and click add -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78395|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78395|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79004&action=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |severine.queune@bulac.fr --- Comment #12 from Séverine Queune <severine.queune@bulac.fr> --- After searching a patron, link to patron account on page '/cgi-bin/koha/members/members-home.pl' is broken when the patch is applied. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79004|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79899&action=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79899|0 |1 is obsolete| | --- Comment #14 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 79943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79943&action=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we adjust the bug title to something more positive? The new modal seems like a nice improvement over the previous behavior and no link was actually removed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79943|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80168&action=edit Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner This patch modifies templates where a pop-up window is used to display patron search results. A link has been added to the patron name which triggers a modal window displaying more details about that patron. With each page in the test plan, check that clicking linked names in search results triggers a modal with the correct data. - Acquisitions -> Vendor -> View basket -> Add user - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record -> Add user - Acquisitions -> Funds -> Edit fund -> Select owner - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add patrons - Serials -> Subscription -> Edit routing list -> Add recipients Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use modal for displaying |Use modal for displaying |patron details on |patron details on |add_user_search.pl to avoid |add_user_search.pl to avoid |redircct |redirect -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.