[Bug 19595] New: Clicking plugin link does not fill item' s date acquired field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Bug ID: 19595 Summary: Clicking plugin link does not fill item's date acquired field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, josef.moravec@gmail.com, katrin.fischer@bsz-bw.de, kyle@bywatersolutions.com, m.de.rooy@rijksmuseum.nl, testopia@bugs.koha-community.org Depends on: 16203 Before Bug 16203, clicking the "..." plugin link on the item add form's date acquired field would insert today's date, overwriting an existing date if present. Now clicking the "..." link does nothing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 [Bug 16203] Convert item plugins to new style (see bug 10480) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I think this is not a bug but a change in behavior. We have cataloging plugins with additional popups and those without such popups. The plugin for date acquired is in the last category. More technically, it has no launcher in its perl script. If you hover your mouse over the "plugin link", you will see "No popup". Iirc another report already mentioned the need for a clearer division. Imo no bug and no rel 17.11 candidate, but something to improve in style for 18.05. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal Keywords|rel_17_11_candidate | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks for the clarification Marcel. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I consider this a bug BECAUSE it is a change in behavior. Functionality which my catalogers used daily has been removed, making their work more difficult. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #1)
If you hover your mouse over the "plugin link", you will see "No popup".
I see "Tag editor" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69082&action=edit Bug 19595: Clicking plugin link does not fill item's date acquired field This patch updates the dateaccessioned plugin for the item edit form to return functionality which was removed in a previous patch. To test, apply the patch and open an item for editing. Clicking the "..." link next to the "Date acquired" field should insert the current date, overwriting the existing date. Open a blank item add form. Putting the cursor in the "Date acquired" field should automatically insert the current date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69082|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69085&action=edit Bug 19595: Clicking plugin link does not fill item's date acquired field This patch updates the dateaccessioned plugin for the item edit form to return functionality which was removed in a previous patch. To test, apply the patch and open an item for editing. Clicking the "..." link next to the "Date acquired" field should insert the current date, overwriting the existing date. Open a blank item add form. Putting the cursor in the "Date acquired" field should automatically insert the current date. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added a comment line in set_to_today. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #4)
(In reply to Marcel de Rooy from comment #1)
If you hover your mouse over the "plugin link", you will see "No popup".
I see "Tag editor"
Caused by the presence of a Click event -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #3)
I consider this a bug BECAUSE it is a change in behavior. Functionality which my catalogers used daily has been removed, making their work more difficult.
There is difficult and difficult :) Clicking in the field would have triggered the Focus event, but indeed it would not overwrite. But overwriting date acquired might not be a good idea most of the time .. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- In view of its rather trivial nature, passing QA in one run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 19644 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org