[Bug 34280] New: Patrons with no email address produce a warning when saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Bug ID: 34280 Summary: Patrons with no email address produce a warning when saving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a patron has no valid email address then a warning message appears in the logs when saving: "Use of uninitialized value $email in string ne at /kohadevbox/koha/Koha/Patron.pm line 1445." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 153490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153490&action=edit Bug 34280: Fix warning in logs when saving patron details If a patron has no valid email address then a warning message appears in the logs when saving: "Use of uninitialized value $email in string ne at /kohadevbox/koha/Koha/Patron.pm line 1445." This patch fixes that error by removing an unnescessary string ne Test plan: 1) Create/choose a patron with no email addresses 2) On the patron record in the page section for Contact information, click edit 3) Now click save 4) The warning above should appear in the logs 5) Apply patch 6) Repeat steps 2 and 3 7) The warning should no longer appear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153490|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 153587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153587&action=edit Bug 34280: Fix warning in logs when saving patron details If a patron has no valid email address then a warning message appears in the logs when saving: "Use of uninitialized value $email in string ne at /kohadevbox/koha/Koha/Patron.pm line 1445." This patch fixes that error by removing an unnescessary string ne Test plan: 1) Create/choose a patron with no email addresses 2) On the patron record in the page section for Contact information, click edit 3) Now click save 4) The warning above should appear in the logs 5) Apply patch 6) Repeat steps 2 and 3 7) The warning should no longer appear Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For me, the warning only appeared in the logs when editing the contact information for existing patrons. If I created a new patron, the warning message didn't appear in the logs. 2. To view the logs: vi /var/log/koha/kohadev/plack-intranet-error.log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153587|0 |1 is obsolete| | --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 153852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153852&action=edit Bug 34280: Fix warning in logs when saving patron details If a patron has no valid email address then a warning message appears in the logs when saving: "Use of uninitialized value $email in string ne at /kohadevbox/koha/Koha/Patron.pm line 1445." This patch fixes that error by removing an unnescessary string ne Test plan: 1) Create/choose a patron with no email addresses 2) On the patron record in the page section for Contact information, click edit 3) Now click save 4) The warning above should appear in the logs 5) Apply patch 6) Repeat steps 2 and 3 7) The warning should no longer appear Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 153853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153853&action=edit Bug 34280: (QA follow-up) perltidy Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Trivial follow-up patch to make perltidy happy. Otherwise, change makes sense and QA tool passes. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like this has been added by Bug 29046 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |pedro.amorim@ptfs-europe.co | |m Status|Pushed to stable |RESOLVED --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Bug 29046 not in 22.11.x. Not pushing. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org