[Bug 15842] New: Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Bug ID: 15842 Summary: Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: kyle@bywatersolutions.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 9303 When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 [Bug 9303] relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15840 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48190&action=edit Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 The same issue seems to occur for sms_provider_id. Test Plan: 1) Attempt to import patron csv file with no privacy_guarantor_checkouts column 2) Note the error 3) Apply this patch 4) Repeat step 1 5) The error should no longer occur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Kyle M Hall from comment #1)
The same issue seems to occur for sms_provider_id.
Confirmed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48190|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 48263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48263&action=edit [SIGNED-OFF] Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 The same issue seems to occur for sms_provider_id. Test Plan: 1) Attempt to import patron csv file with no privacy_guarantor_checkouts column 2) Note the error 3) Apply this patch 4) Repeat step 1 5) The error should no longer occur NOTE: While this patch does work, should it be solved only at this level? The issue that there is the lack of those two fields on the tools screen still exists. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15840 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15840 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 [Bug 15840] Import borrowers tool explodes if userid already exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #3)
NOTE: While this patch does work, should it be solved only at this level? The issue that there is the lack of those two fields on the tools screen still exists.
Could you detail? I don't understand what you suggest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #4)
Could you detail? I don't understand what you suggest.
"The issue that there is the lack of those two fields on the tools screen still exists." If they did exist, then I think the issue would be corrected in part (not in whole) from the proper use of the UI. Whereas, a crafted direct call would still be buggy. This corrects both, but it still leaves the UI incomplete (missing the SMS and guarantor fields). No warning messages tends to leave the problem unfixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if those 2 are interesting for patron load, but maybe in the context of migrations? Adding to the tool page could go on a separate bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #6)
I wonder if those 2 are interesting for patron load, but maybe in the context of migrations? Adding to the tool page could go on a separate bug report.
That works for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48263|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48434&action=edit Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768 The same issue seems to occur for sms_provider_id. Test Plan: 1) Attempt to import patron csv file with no privacy_guarantor_checkouts column 2) Note the error 3) Apply this patch 4) Repeat step 1 5) The error should no longer occur NOTE: While this patch does work, should it be solved only at this level? The issue that there is the lack of those two fields on the tools screen still exists. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |julian.maurice@biblibre.com Status|Pushed to Master |RESOLVED --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Does not concern stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org