https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36166 [Bug 36166] Disable select to add to list if opacuserlogin is disabled -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163575&action=edit Bug 36207: Use confirmation modal when removing tags from titles in the OPAC This patch changes the process of removing a tag from a title on the user's tag list. It now uses a confirmation modal dialog instead of a JavaScript alert. The patch also makes some minor tweaks to CSS to correct style on "remove" links. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC as a user who has submitted multiple tags or tags on multiple items. - Open the "Tags" link in the sidebar of the user summary page. - Click the "Remove tag" link next to one of the titles in the table of the user's tags. - You should see a modal confirmation message, "Are you sure you want to remove the selected tag from this title?" It should show the title and the tag which will be removed. - Test both the "Yes, remove tag" and "No, do not remove tag" choices. - Check the box next to one of the tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title and the tag which will be removed. - Test boh the "Yes" and "No" choices. - Check the box next to multiple tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove the selected tags from these titles" It should show the titles of all the records you selected and the corresponding tags to be removed. - Test both the "Yes" and "No" choices. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163575|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163578&action=edit Bug 36207: Use confirmation modal when removing tags from titles in the OPAC This patch changes the process of removing a tag from a title on the user's tag list. It now uses a confirmation modal dialog instead of a JavaScript alert. The patch also makes some minor tweaks to CSS to correct style on "remove" links. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC as a user who has submitted multiple tags or tags on multiple items. - Open the "Tags" link in the sidebar of the user summary page. - Click the "Remove tag" link next to one of the titles in the table of the user's tags. - You should see a modal confirmation message, "Are you sure you want to remove the selected tag from this title?" It should show the title and the tag which will be removed. - Test both the "Yes, remove tag" and "No, do not remove tag" choices. - Check the box next to one of the tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title and the tag which will be removed. - Test boh the "Yes" and "No" choices. - Check the box next to multiple tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove the selected tags from these titles" It should show the titles of all the records you selected and the corresponding tags to be removed. - Test both the "Yes" and "No" choices. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - <form id="deletetags" method="post" action="opac-tags.pl"> - [% INCLUDE 'csrf-token.inc' %] + <form method="post" action="opac-tags.pl"> + <table id="mytagst" class="table table-bordered table-striped"> You remove a CSRF token ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- The patch no longer applies (is a dependency for bug 36166): git bz apply 36207 Bug 36207 - Convert browser alerts to modals: OPAC tags 163578 - Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss error: Failed to merge in the changes. Patch failed at 0001 Bug 36207: Use confirmation modal when removing tags from titles in the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163578|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166212&action=edit Bug 36207: Use confirmation modal when removing tags from titles in the OPAC This patch changes the process of removing a tag from a title on the user's tag list. It now uses a confirmation modal dialog instead of a JavaScript alert. The patch also makes some minor tweaks to CSS to correct style on "remove" links. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC as a user who has submitted multiple tags or tags on multiple items. - Open the "Tags" link in the sidebar of the user summary page. - Click the "Remove tag" link next to one of the titles in the table of the user's tags. - You should see a modal confirmation message, "Are you sure you want to remove the selected tag from this title?" It should show the title and the tag which will be removed. - Test both the "Yes, remove tag" and "No, do not remove tag" choices. - Check the box next to one of the tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove this item from the list?" It should show the title and the tag which will be removed. - Test boh the "Yes" and "No" choices. - Check the box next to multiple tagged titles and click the "Remove selected tags" button at the bottom of the table. - You should see a modal confirmation message, "Are you sure you want to remove the selected tags from these titles" It should show the titles of all the records you selected and the corresponding tags to be removed. - Test both the "Yes" and "No" choices. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice improvement, works as described. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Convert browser alerts to |Update browser alerts to |modals: OPAC tags |modals: OPAC tags -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up confirmed working by Owen and now Pushed by Martin. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34478 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This changes the process |This changes the process release notes|for removing a tag from a |for removing a tag from a |title on the user's tag |title on a patron's tag |list (OPAC > Your account > |list (OPAC > Your account > |Tags). It now uses a |Tags). It now uses a |confirmation dialog box |confirmation dialog box |instead of a JavaScript |instead of a JavaScript |alert. It also makes some |alert. It also makes some |minor tweaks to the CSS to |minor tweaks to the CSS to |correct the style for |correct the style for |"Remove tag" links. |"Remove tag" links. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 Bug 36207 depends on bug 34478, which changed state. Bug 34478 Summary: Full CSRF protection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.