[Bug 26160] New: Add column configuration to sales table to allow hiding of 'Code' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Bug ID: 26160 Summary: Add column configuration to sales table to allow hiding of 'Code' column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 23354 Blocks: 13985 Some people may want the CODE field to appear, whilst others are happy with just the Description.. we should allow for this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107892&action=edit Bug 26160: Make POS items table configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107892|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 108007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108007&action=edit Bug 26160: Make POS items table configurable Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Test Plan: 1) System preference: EnablePointOfSale - set to Enable 2) System preference: UseCashRegisters - set to Use 3) Administration > Accounting > Cash registers - create a new cash register for the library you're logged in as 4) Administration > Accounting > Debit types - create at least one debit type 5) Home > Point of sale - verify that all four columns exist in the Items for purchase table: Code, Description, Cost, Action 6) Administration > Additional parameters > Table settings > Point of sale - change which columns can be hidden and/or toggled 7) Home > Point of sale - verify that your choices have been implemented (columns are hidden, columns can be toggled, columns can't be toggled) 8) Repeat steps 6 and 7 for different combinations, checking that they all work. Works great, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should by default not print/export the Actions column, but this is currently not handled consistenty on other tables - it doesn't print for itemtypes, but it does for libraries. So not failing solely for this reason. This might also need some additional styling work - I filed bug 26189 for that as the display is not perfect right now either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108007|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108014&action=edit Bug 26160: Make POS items table configurable 1) System preference: EnablePointOfSale - set to Enable 2) System preference: UseCashRegisters - set to Use 3) Administration > Accounting > Cash registers - create a new cash register for the library you're logged in as 4) Administration > Accounting > Debit types - create at least one debit type 5) Home > Point of sale - verify that all four columns exist in the Items for purchase table: Code, Description, Cost, Action 6) Administration > Additional parameters > Table settings > Point of sale - change which columns can be hidden and/or toggled 7) Home > Point of sale - verify that your choices have been implemented (columns are hidden, columns can be toggled, columns can't be toggled) 8) Repeat steps 6 and 7 for different combinations, checking that they all work. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Added Sally's test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #4)
I think we should by default not print/export the Actions column, but this is currently not handled consistenty on other tables - it doesn't print for itemtypes, but it does for libraries. So not failing solely for this reason.
This might also need some additional styling work - I filed bug 26189 for that as the display is not perfect right now either.
I actually asked on IRC about removing the export/print option entirely as I don't feel you would want to do that here.. but I was warned against it as it would entail changing more base code in KohaTable. I may open another bug for that sometime soon however. Thanks for the QA. 😀 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It does not display nicely for me: https://snipboard.io/irsbW8.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #7)
It does not display nicely for me: https://snipboard.io/irsbW8.jpg
Katrin raised this as another bug, styling issues were present prior to this bug (I've not managed to work out how to resolve them and have asked for some help on IRC) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26189 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26189 [Bug 26189] Table options on points of sale misaligned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108102&action=edit Bug 26160: (follow-up) Improve styling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor improvements above to make dataTables styling more consistent when found within a 'fieldset class="rows"' element.. Still needs some work to get the alignment working but I've hit a dead end.. hoping someone can take a look and help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can you move your patch to bug 26189 please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #11)
Can you move your patch to bug 26189 please?
Done, thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will bot be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26160 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add column configuration to |Add column configuration to |sales table to allow hiding |the Point of sale, Items |of 'Code' column |for purchase table -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org