[Bug 30922] New: moremember.pl column settings aren't working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Bug ID: 30922 Summary: moremember.pl column settings aren't working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: marie-luce.laflamme@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com the Patron > moremember > issues-table are not applied correctly. If you hide columns, hidden columns are still displayed in the relative's checkouts. 1. Go to admin > Table settings > Patron > moremember > issues-table 2. Hide few columns (e.g. record_type) 3. Find a patron account 4. Checkout an item 5. Add a guarantee to this account 6. Check the "relatives' checkouts" tab All the columns are still visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|moremember.pl column |Make the "Relative's |settings aren't working |checkouts" table | |configurable by the table | |settings CC| |jonathan.druart+koha@gmail. | |com Severity|normal |enhancement --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It's not that is not working, it's not the same table. The "relative's checkouts" table is not part of the table settings yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 --- Comment #2 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 137218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137218&action=edit Bug 30922: Make the "Relative's checkouts" table configurable by the table settings Adds "relatives-issues-table" in table settings. Test plan: 1- Apply the patch 2- Check out an item to a patron with a guarantor 3- Go to the guarantor's "details" and "check out" page > relatives' checkouts and look at the different columns (you should see collection and location) 4- Go to admin > table settings > patron > moremember > relatives-issues-table or admin > table settings > circulation > circulation > relatives-issues-table to hide some columns (e.g. collection and location) and click save 5- Do step 3 again and notice some columns (e.g. collection and location) are hidden -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |shi-yao.wang@inLibro.com |ity.org | Status|NEW |Needs Signoff CC| |philippe.blouin@inlibro.com | |, shi-yao.wang@inLibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- A couple of comments from testing: 1. This works for the relatives' checkouts tab on the check out and details sections of the patron's page. 2. Normally, when the table settings are configurable, there is a 'Columns' button above the actual table that lets you toggle the columns on and off. I'm not seeing it for this table. For an example, check out something to the guarantor and you should see what I mean. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137218|0 |1 is obsolete| | --- Comment #4 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 137332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137332&action=edit Bug 30922: Make the "Relative's checkouts" table configurable by the table settings Adds "relatives-issues-table" in table settings. Test plan: 1- Apply the patch 2- Check out an item to a patron with a guarantor 3- Go to the guarantor's "details" and "check out" page > relatives' checkouts and look at the different columns (you should see collection and location) 4- Go to admin > table settings > patron > moremember > relatives-issues-table or admin > table settings > circulation > circulation > relatives-issues-table to hide some columns (e.g. collection and location) and click save 5- Do step 3 again and notice some columns (e.g. collection and location) are hidden 6- Also notice the "Columns" and "Export" buttons that should work as intended -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137332|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 137334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137334&action=edit Bug 30922: Make the "Relative's checkouts" table configurable by the table settings Adds "relatives-issues-table" in table settings. Test plan: 1- Apply the patch 2- Check out an item to a patron with a guarantor 3- Go to the guarantor's "details" and "check out" page > relatives' checkouts and look at the different columns (you should see collection and location) 4- Go to admin > table settings > patron > moremember > relatives-issues-table or admin > table settings > circulation > circulation > relatives-issues-table to hide some columns (e.g. collection and location) and click save 5- Do step 3 again and notice some columns (e.g. collection and location) are hidden 6- Also notice the "Columns" and "Export" buttons that should work as intended Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've compared in colum_settings.yaml 'issues-table' and 'relatives-issues-table'. We see that 'homebranch' is missing from relatives issues table. But it is also missing in checkouts.js so it is for another bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- I imagine no one would like to hide the "patron" column but we can keep it configurable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137334|0 |1 is obsolete| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 139089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139089&action=edit Bug 30922: Make the "Relative's checkouts" table configurable by the table settings Adds "relatives-issues-table" in table settings. Test plan: 1- Apply the patch 2- Check out an item to a patron with a guarantor 3- Go to the guarantor's "details" and "check out" page > relatives' checkouts and look at the different columns (you should see collection and location) 4- Go to admin > table settings > patron > moremember > relatives-issues-table or admin > table settings > circulation > circulation > relatives-issues-table to hide some columns (e.g. collection and location) and click save 5- Do step 3 again and notice some columns (e.g. collection and location) are hidden 6- Also notice the "Columns" and "Export" buttons that should work as intended Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31359 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancment will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org